Skip to content

Commit 842b64e

Browse files
committed
pr review
1 parent edab014 commit 842b64e

File tree

2 files changed

+0
-24
lines changed
  • javaagent-tooling/src

2 files changed

+0
-24
lines changed

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/Utils.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,16 +41,6 @@ public static String getResourceName(String className) {
4141
return className.replace('.', '/') + ".class";
4242
}
4343

44-
/** com/foo/Bar to com.foo.Bar */
45-
public static String getClassName(String internalName) {
46-
return internalName.replace('/', '.');
47-
}
48-
49-
/** com.foo.Bar to com/foo/Bar */
50-
public static String getInternalName(Class<?> clazz) {
51-
return clazz.getName().replace('.', '/');
52-
}
53-
5444
/**
5545
* Get method definition for given {@link TypeDefinition} and method name.
5646
*

javaagent-tooling/src/test/java/io/opentelemetry/javaagent/tooling/UtilsTest.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,4 @@ void getResourceNameAddsSuffixAndConvertDotsToSlashes() {
1717

1818
assertThat(result).isEqualTo("com/example/Something.class");
1919
}
20-
21-
@Test
22-
void getClassNameConvertsSlashesToDots() {
23-
String result = Utils.getClassName("com/example/Something");
24-
25-
assertThat(result).isEqualTo("com.example.Something");
26-
}
27-
28-
@Test
29-
void getInternalNameConvertsSlashesToDots() {
30-
String result = Utils.getInternalName(UtilsTest.class);
31-
32-
assertThat(result).isEqualTo("io/opentelemetry/javaagent/tooling/UtilsTest");
33-
}
3420
}

0 commit comments

Comments
 (0)