Skip to content

Commit 85aaaaa

Browse files
committed
fix
1 parent 45c7510 commit 85aaaaa

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/build.gradle.kts

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,27 +22,25 @@ tasks {
2222
systemProperty("testLatestDeps", findProperty("testLatestDeps") as Boolean)
2323
}
2424

25-
val testReceiveSpansDisabled by registering(Test::class) {
26-
testClassesDirs = sourceSets.test.get().output.classesDirs
27-
classpath = sourceSets.test.get().runtimeClasspath
25+
test {
2826
filter {
29-
includeTestsMatching("InterceptorsSuppressReceiveSpansTest")
30-
includeTestsMatching("WrapperSuppressReceiveSpansTest")
27+
excludeTestsMatching("*DeprecatedInterceptorsTest")
3128
}
32-
include("**/InterceptorsSuppressReceiveSpansTest.*", "**/WrapperSuppressReceiveSpansTest.*")
29+
systemProperty("otel.instrumentation.messaging.experimental.capture-headers", "Test-Message-Header")
3330
}
3431

35-
test {
32+
val testDeprecated by registering(Test::class) {
33+
testClassesDirs = sourceSets.test.get().output.classesDirs
34+
classpath = sourceSets.test.get().runtimeClasspath
3635
filter {
37-
excludeTestsMatching("InterceptorsSuppressReceiveSpansTest")
38-
excludeTestsMatching("WrapperSuppressReceiveSpansTest")
36+
includeTestsMatching("*DeprecatedInterceptorsTest")
3937
}
40-
jvmArgs("-Dotel.instrumentation.messaging.experimental.receive-telemetry.enabled=true")
38+
systemProperty("otel.instrumentation.messaging.experimental.receive-telemetry.enabled", "true")
4139
systemProperty("otel.instrumentation.messaging.experimental.capture-headers", "Test-Message-Header")
4240
}
4341

4442
check {
45-
dependsOn(testReceiveSpansDisabled)
43+
dependsOn(testDeprecated)
4644
}
4745
}
4846

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/AbstractDeprecatedInterceptorsTest.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,12 @@ abstract class AbstractDeprecatedInterceptorsTest extends KafkaClientBaseTest {
2828

2929
static final String greeting = "Hello Kafka!";
3030

31-
private static final KafkaTelemetry kafkaTelemetry =
32-
KafkaTelemetry.create(testing.getOpenTelemetry());
33-
3431
@SuppressWarnings("deprecation") // testing deprecated interceptors
3532
@Override
3633
public Map<String, Object> producerProps() {
3734
Map<String, Object> props = super.producerProps();
3835
props.put(
3936
ProducerConfig.INTERCEPTOR_CLASSES_CONFIG, TracingProducerInterceptor.class.getName());
40-
props.putAll(kafkaTelemetry.producerInterceptorConfigProperties());
4137
return props;
4238
}
4339

@@ -47,7 +43,6 @@ public Map<String, Object> consumerProps() {
4743
Map<String, Object> props = super.consumerProps();
4844
props.put(
4945
ConsumerConfig.INTERCEPTOR_CLASSES_CONFIG, TracingConsumerInterceptor.class.getName());
50-
props.putAll(kafkaTelemetry.consumerInterceptorConfigProperties());
5146
return props;
5247
}
5348

@@ -95,3 +90,4 @@ void testInterceptors() throws InterruptedException {
9590

9691
abstract void assertTraces();
9792
}
93+

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/AbstractInterceptorsTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,9 @@ abstract class AbstractInterceptorsTest extends KafkaClientBaseTest {
2727
static final String greeting = "Hello Kafka!";
2828

2929
private static final KafkaTelemetry kafkaTelemetry =
30-
KafkaTelemetry.create(testing.getOpenTelemetry());
30+
KafkaTelemetry.builder(testing.getOpenTelemetry())
31+
.setMessagingReceiveInstrumentationEnabled(true)
32+
.build();
3133

3234
@Override
3335
public Map<String, Object> producerProps() {

0 commit comments

Comments
 (0)