Skip to content

Commit 85beb7a

Browse files
committed
fix comments
1 parent 712c70d commit 85beb7a

File tree

1 file changed

+2
-6
lines changed
  • instrumentation/internal/internal-class-loader/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/classloader

1 file changed

+2
-6
lines changed

instrumentation/internal/internal-class-loader/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/classloader/DefineClassInstrumentation.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,7 @@ public static DefineClassContext onEnter(
5454

5555
// TODO: the ToReturned does nothing except for signaling the AdviceTransformer that it must
5656
// not touch this advice
57-
// this is done to ensure that ClassLoaderInstrumentationModule.loadAdviceClassesEagerly works
58-
// correctly
59-
// we can therefore remove it, as soon as the AdviceTransformer is not applied anymore
57+
// this is done because we do not want the return values to be wrapped in array types
6058
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
6159
@Advice.AssignReturned.ToReturned
6260
public static Class<?> onExit(
@@ -78,9 +76,7 @@ public static DefineClassContext onEnter(
7876

7977
// TODO: the ToReturned does nothing except for signaling the AdviceTransformer that it must
8078
// not touch this advice
81-
// this is done to ensure that ClassLoaderInstrumentationModule.loadAdviceClassesEagerly works
82-
// correctly
83-
// we can therefore remove it, as soon as the AdviceTransformer is not applied anymore
79+
// this is done because we do not want the return values to be wrapped in array types
8480
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
8581
@Advice.AssignReturned.ToReturned
8682
public static Class<?> onExit(

0 commit comments

Comments
 (0)