Skip to content

Commit 88be41e

Browse files
committed
remove methods that are only needed by contrib
1 parent ac02271 commit 88be41e

File tree

4 files changed

+20
-7
lines changed

4 files changed

+20
-7
lines changed

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/internal/ConfigPropertiesTranslator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.javaagent.extension.internal;
77

8-
98
import java.util.LinkedHashMap;
109
import java.util.Map;
1110

@@ -30,8 +29,8 @@ String translateProperty(String property) {
3029
return property;
3130
}
3231

32+
@Nullable
3333
public Object get(String propertyName) {
3434
return fixedValues.get(propertyName);
3535
}
36-
3736
}

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/internal/DeclarativeConfigPropertiesBridgeBuilder.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
16
package io.opentelemetry.javaagent.extension.internal;
27

38
import static io.opentelemetry.api.incubator.config.DeclarativeConfigProperties.empty;
@@ -13,8 +18,11 @@
1318
import javax.annotation.Nullable;
1419

1520
/**
16-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
17-
* any time.
21+
* A builder for {@link DeclarativeConfigPropertiesBridge} that allows adding translations and fixed
22+
* values for properties.
23+
*
24+
* <p>This class is internal and is hence not for public use. Its APIs are unstable and can change
25+
* at any time.
1826
*/
1927
public class DeclarativeConfigPropertiesBridgeBuilder {
2028
private final LinkedHashMap<String, String> translationMap = new LinkedHashMap<>();

javaagent-extension-api/src/test/java/io/opentelemetry/javaagent/extension/internal/DeclarativeConfigPropertiesBridgeBuilderTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
16
package io.opentelemetry.javaagent.extension.internal;
27

38
import static org.assertj.core.api.Assertions.assertThat;

javaagent-extension-api/src/test/java/io/opentelemetry/javaagent/extension/internal/DeclarativeConfigPropertiesBridgeTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ void setup() {
3939
Objects.requireNonNull(emptyConfigProvider.getInstrumentationConfig()));
4040
}
4141

42-
private static ConfigProperties create(
43-
DeclarativeConfigPropertiesBridgeBuilder builder) {
42+
private static ConfigProperties create(DeclarativeConfigPropertiesBridgeBuilder builder) {
4443
OpenTelemetryConfigurationModel model =
4544
DeclarativeConfiguration.parse(
4645
DeclarativeConfigPropertiesBridgeTest.class
@@ -125,7 +124,9 @@ void vendor() {
125124
@Test
126125
void vendorTranslation() {
127126
ConfigProperties propertiesBridge =
128-
create(new DeclarativeConfigPropertiesBridgeBuilder().addTranslation("acme", "acme.full_name"));
127+
create(
128+
new DeclarativeConfigPropertiesBridgeBuilder()
129+
.addTranslation("acme", "acme.full_name"));
129130
assertThat(propertiesBridge.getBoolean("acme.preserved")).isTrue();
130131
}
131132

0 commit comments

Comments
 (0)