fix signature erasure for types in java package that contain $

laurit · laurit · commit 8913d3fcad3b · 2024-12-20T17:04:39.000+02:00
diff --git a/javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/indy/AdviceSignatureEraser.java b/javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/indy/AdviceSignatureEraser.java
@@ -85,7 +85,7 @@ private static String eraseTypes(String descriptor) {
       String reference = matcher.group();
       if (reference.startsWith("Ljava/")) {
         // do not erase java.* references
-        matcher.appendReplacement(result, reference);
+        matcher.appendReplacement(result, Matcher.quoteReplacement(reference));
       } else {
         matcher.appendReplacement(result, "Ljava/lang/Object;");
       }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ private static String eraseTypes(String descriptor) {`
`85`	`85`	`String reference = matcher.group();`
`86`	`86`	`if (reference.startsWith("Ljava/")) {`
`87`	`87`	`// do not erase java.* references`
`88`		`- matcher.appendReplacement(result, reference);`
	`88`	`+ matcher.appendReplacement(result, Matcher.quoteReplacement(reference));`
`89`	`89`	`} else {`
`90`	`90`	`matcher.appendReplacement(result, "Ljava/lang/Object;");`
`91`	`91`	`}`