Skip to content

Commit 89363d2

Browse files
committed
wip: fixing checkstyle violations in testing folder files.
1 parent 7cd1eef commit 89363d2

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

instrumentation/kafka/kafka-connect-2.6/testing/src/test/java/io/opentelemetry/instrumentation/kafkaconnect/v2_6/MongoKafkaConnectSinkTaskTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ private static int getRandomFreePort() {
489489
try (ServerSocket serverSocket = new ServerSocket(0)) {
490490
return serverSocket.getLocalPort();
491491
} catch (IOException e) {
492-
e.printStackTrace();
492+
logger.error("Failed to get random free port", e);
493493
return 0;
494494
}
495495
}

instrumentation/kafka/kafka-connect-2.6/testing/src/test/java/io/opentelemetry/instrumentation/kafkaconnect/v2_6/PostgresKafkaConnectSinkTaskTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ public static void cleanup() {
417417
try {
418418
adminClient.close();
419419
} catch (RuntimeException e) {
420-
System.err.println("Error closing AdminClient: " + e.getMessage());
420+
logger.error("Error closing AdminClient: " + e.getMessage());
421421
}
422422
}
423423

@@ -427,47 +427,47 @@ public static void cleanup() {
427427
kafkaConnect.stop();
428428
} catch (RuntimeException e) {
429429
// Log but don't fail cleanup
430-
System.err.println("Error stopping Kafka Connect: " + e.getMessage());
430+
logger.error("Error stopping Kafka Connect: " + e.getMessage());
431431
}
432432
}
433433

434434
if (postgreSql != null) {
435435
try {
436436
postgreSql.stop();
437437
} catch (RuntimeException e) {
438-
System.err.println("Error stopping PostgreSQL: " + e.getMessage());
438+
logger.error("Error stopping PostgreSQL: " + e.getMessage());
439439
}
440440
}
441441

442442
if (kafka != null) {
443443
try {
444444
kafka.stop();
445445
} catch (RuntimeException e) {
446-
System.err.println("Error stopping Kafka: " + e.getMessage());
446+
logger.error("Error stopping Kafka: " + e.getMessage());
447447
}
448448
}
449449

450450
if (zookeeper != null) {
451451
try {
452452
zookeeper.stop();
453453
} catch (RuntimeException e) {
454-
System.err.println("Error stopping Zookeeper: " + e.getMessage());
454+
logger.error("Error stopping Zookeeper: " + e.getMessage());
455455
}
456456
}
457457

458458
if (backend != null) {
459459
try {
460460
backend.stop();
461461
} catch (RuntimeException e) {
462-
System.err.println("Error stopping backend: " + e.getMessage());
462+
logger.error("Error stopping backend: " + e.getMessage());
463463
}
464464
}
465465

466466
if (network != null) {
467467
try {
468468
network.close();
469469
} catch (RuntimeException e) {
470-
System.err.println("Error closing network: " + e.getMessage());
470+
logger.error("Error closing network: " + e.getMessage());
471471
}
472472
}
473473

@@ -522,9 +522,9 @@ private static void setupSinkConnector(String topicName) throws IOException {
522522
// Remove this problematic cleanup code:
523523
// try (AdminClient adminClient = createAdminClient()) {
524524
// adminClient.deleteTopics(Collections.singletonList(TOPIC_NAME)).all().get();
525-
// System.out.println("Deleted existing topic: " + TOPIC_NAME);
525+
// logger.info("Deleted existing topic: " + TOPIC_NAME);
526526
// } catch (e instanceof InterruptedException) {
527-
// System.out.println("Topic cleanup: " + e.getMessage());
527+
// logger.info("Topic cleanup: " + e.getMessage());
528528
// }
529529
}
530530

0 commit comments

Comments
 (0)