Skip to content

Commit 8a38fb4

Browse files
committed
fix comments on non public classes, remove unneeded instrumentation name
1 parent 5b97714 commit 8a38fb4

File tree

13 files changed

+1
-54
lines changed

13 files changed

+1
-54
lines changed

instrumentation/mongo/mongo-3.1/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mongo/v3_1/MongoClientTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@ class MongoClientTest extends AbstractMongo31ClientTest {
1919
@Override
2020
protected void configureMongoClientOptions(MongoClientOptions.Builder options) {}
2121

22-
@Override
23-
protected String instrumentationName() {
24-
return "io.opentelemetry.mongo-3.1";
25-
}
26-
2722
@Override
2823
protected InstrumentationExtension testing() {
2924
return testing;

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/MongoAttributesExtractor.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@
2020
import javax.annotation.Nullable;
2121
import org.bson.BsonValue;
2222

23-
/**
24-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
25-
* any time.
26-
*/
2723
class MongoAttributesExtractor implements AttributesExtractor<CommandStartedEvent, Void> {
2824
// copied from DbIncubatingAttributes
2925
private static final AttributeKey<String> DB_MONGODB_COLLECTION =

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/MongoDbAttributesGetter.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@
2424
import org.bson.json.JsonWriter;
2525
import org.bson.json.JsonWriterSettings;
2626

27-
/**
28-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
29-
* any time.
30-
*/
3127
class MongoDbAttributesGetter implements DbClientAttributesGetter<CommandStartedEvent, Void> {
3228

3329
// copied from DbIncubatingAttributes.DbSystemIncubatingValues

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/MongoNetworkAttributesGetter.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
import io.opentelemetry.instrumentation.api.semconv.network.ServerAttributesGetter;
1010
import javax.annotation.Nullable;
1111

12-
/**
13-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
14-
* any time.
15-
*/
1612
class MongoNetworkAttributesGetter implements ServerAttributesGetter<CommandStartedEvent> {
1713

1814
@Nullable

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/MongoSpanNameExtractor.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@
88
import com.mongodb.event.CommandStartedEvent;
99
import io.opentelemetry.instrumentation.api.instrumenter.SpanNameExtractor;
1010

11-
/**
12-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
13-
* any time.
14-
*/
1511
class MongoSpanNameExtractor implements SpanNameExtractor<CommandStartedEvent> {
1612
private static final String DEFAULT_SPAN_NAME = "DB Query";
1713

instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/internal/StringBuilderWriter.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,6 @@
77

88
import java.io.Writer;
99

10-
/**
11-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
12-
* any time.
13-
*/
1410
// because StringWriter uses the synchronized StringBuffer
1511
class StringBuilderWriter extends Writer {
1612

instrumentation/mongo/mongo-3.1/library/src/test/java/io/opentelemetry/instrumentation/mongo/v3_1/MongoClientTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ class MongoClientTest extends AbstractMongo31ClientTest {
1515
@RegisterExtension
1616
private static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
1717

18-
@Override
19-
protected String instrumentationName() {
20-
return "io.opentelemetry.mongo-3.1";
21-
}
22-
2318
@Override
2419
protected void configureMongoClientOptions(MongoClientOptions.Builder options) {
2520
options.addCommandListener(

instrumentation/mongo/mongo-3.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/mongo/v3_7/MongoInstrumentationSingletons.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ public final class MongoInstrumentationSingletons {
2323
AgentInstrumentationConfig.get()
2424
.getBoolean(
2525
"otel.instrumentation.mongo.statement-sanitizer.enabled",
26-
AgentCommonConfig.get().isStatementSanitizationEnabled()),
27-
32 * 1024); // DEFAULT_MAX_NORMALIZED_QUERY_LENGTH
26+
AgentCommonConfig.get().isStatementSanitizationEnabled()));
2827

2928
public static final CommandListener LISTENER = new TracingCommandListener(INSTRUMENTER);
3029

instrumentation/mongo/mongo-3.7/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mongo/v3_7/MongoClientTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@
3333
import org.junit.jupiter.api.extension.RegisterExtension;
3434

3535
class MongoClientTest extends AbstractMongoClientTest<MongoCollection<Document>> {
36-
37-
@Override
38-
protected String instrumentationName() {
39-
return "io.opentelemetry.mongo-3.7";
40-
}
41-
4236
@RegisterExtension
4337
static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
4438

instrumentation/mongo/mongo-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/mongo/v4_0/Mongo4ReactiveClientTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,6 @@
3636
import org.reactivestreams.Subscription;
3737

3838
class Mongo4ReactiveClientTest extends AbstractMongoClientTest<MongoCollection<Document>> {
39-
@Override
40-
protected String instrumentationName() {
41-
return "io.opentelemetry.mongo-4.0";
42-
}
4339

4440
@RegisterExtension
4541
static final InstrumentationExtension testing = AgentInstrumentationExtension.create();

0 commit comments

Comments
 (0)