Fix compilation errors and formatting issues

- Fix RuntimeConfigProperties to use EmptyConfigProperties.INSTANCE instead of new
- Make deprecated configure() method default in IgnoredTypesConfigurer interface
- Migrate IgnoredTypesConfigurer implementations to use DeclarativeConfigUtil with GlobalOpenTelemetry
- Add @SuppressWarnings with explanatory comments for deprecated API usage in fallback paths
- Fix spotless formatting in OpenTelemetryAutoConfiguration

Author: trask

CI-PLAN.md

@@ -1,23 +1,42 @@
 # CI Failure Analysis Plan
 
 ## Failed Jobs Summary
-- Multiple test jobs (test0, test1, test2, test3 across Java 8, 11, 17, 21, 25 with various indy settings)
-- testLatestDeps jobs (0, 1, 2, 3)
+
+- Job: common / spotless (job ID: 57983607252)
+- Job: common / build (job ID: 57983607261)
+- Job: Analyze (java) (job ID: 57983599428)
+- Job: markdown-lint-check / markdown-lint-check (job ID: 57983607254)
+- Multiple test jobs (test0, test1, test2, test3) across different Java versions
+- Multiple smoke-test jobs
+- common / examples
+- testLatestDeps (0-3)
+- muzzle (1-4)
 
 ## Unique Failed Gradle Tasks
 
-- [ ] Task: :instrumentation-api-incubator:javaagent-testing:test
-  - Seen in: test1 (Java 8, indy false)
-  - Log files: /tmp/test1-java8-indy-false.log
-  - Failure: Test assertions failing for http.response.body.size attribute
+- [x] Task: :instrumentation:spring:spring-boot-autoconfigure:spotlessJavaCheck
+  - Seen in: common / spotless, common / build
+  - Log files: /tmp/spotless.log, /tmp/build.log
+  - Issue: Format violation in OpenTelemetryAutoConfiguration.java
+  - Fix: Ran spotlessApply to fix formatting
+
+- [x] Task: :javaagent-tooling:compileJava
+  - Seen in: common / build, all test jobs, all smoke-test jobs, examples, testLatestDeps, muzzle
+  - Log files: /tmp/build.log, /tmp/test0-java8.log, /tmp/examples.log
+  - Issue: Compilation errors - cannot find symbol EmptyConfigProperties, and IgnoredTypesConfigurer implementations missing required method
+  - Fix: 
+    - Fixed EmptyConfigProperties instantiation to use INSTANCE instead of new
+    - Made deprecated configure(builder, config) method default in IgnoredTypesConfigurer
+    - Updated IgnoredTypesConfigurer implementations to use deprecated method when config is needed
+    - Added @SuppressWarnings("deprecation") with comments to all deprecated API usage
 
-- [ ] Task: :smoke-tests-otel-starter:spring-boot-2:testDeclarativeConfig  
-  - Seen in: test1 (Java 8, indy false)
-  - Log files: /tmp/test1-java8-indy-false.log
-  - Failure: 6 tests failed - AssertionError for [LONG attribute 'http.response.body.size'] - Expecting actual not to be null
+- [ ] Task: markdown-lint-check
+  - Seen in: markdown-lint-check / markdown-lint-check
+  - Log files: /tmp/markdown-lint.log
+  - Issue: CI-PLAN.md format violations (will be fixed by not committing this file)
 
 ## Notes
-- All failures appear related to missing `http.response.body.size` attribute in test assertions
-- The attribute is expected to be present in HTTP spans but is null
-- This is likely related to the declarative-configuration-bridge changes
-- Both regular instrumentation API tests and Spring Boot smoke tests are affected
+
+- All failures appear related to the declarative-configuration-bridge changes
+- The compilation error in javaagent-tooling is the root cause blocking all downstream jobs
+- Need to fix: EmptyConfigProperties missing class and IgnoredTypesConfigurer interface changes

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java

@@ -165,8 +165,7 @@ public OpenTelemetryConfigurationModel openTelemetryConfigurationModel(
 
       @Bean
       public OpenTelemetry openTelemetry(
-          OpenTelemetryConfigurationModel model,
-          ApplicationContext applicationContext) {
+          OpenTelemetryConfigurationModel model, ApplicationContext applicationContext) {
         ExtendedOpenTelemetrySdk sdk =
             DeclarativeConfiguration.create(
                 model, new OpenTelemetrySdkComponentLoader(applicationContext));

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/ignore/IgnoredTypesConfigurer.java

@@ -33,5 +33,7 @@ default void configure(IgnoredTypesBuilder builder) {
    * @deprecated Use {@link #configure(IgnoredTypesBuilder)} instead.
    */
   @Deprecated
-  void configure(IgnoredTypesBuilder builder, ConfigProperties config);
+  default void configure(IgnoredTypesBuilder builder, ConfigProperties config) {
+    configure(builder);
+  }
 }

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentInstaller.java

@@ -185,7 +185,9 @@ private static void installBytebuddyAgent(
           agentBuilder = agentExtension.extend(agentBuilder);
         } catch (UnsupportedOperationException e) {
           // fall back to the deprecated method
-          agentBuilder = agentExtension.extend(agentBuilder, RuntimeConfigProperties.get());
+          @SuppressWarnings("deprecation")
+          AgentBuilder extended = agentExtension.extend(agentBuilder, RuntimeConfigProperties.get());
+          agentBuilder = extended;
         }
         numberOfLoadedExtensions++;
       } catch (Exception | LinkageError e) {
@@ -289,6 +291,8 @@ private static void copyNecessaryConfigToSystemProperties() {
                     "otel.instrumentation.experimental.span-suppression-strategy", value));
   }
 
+  // Need to call deprecated API for backward compatibility with extensions that haven't migrated
+  @SuppressWarnings("deprecation")
   private static void setBootstrapPackages(ClassLoader extensionClassLoader) {
     BootstrapPackagesBuilderImpl builder = new BootstrapPackagesBuilderImpl();
     for (BootstrapPackagesConfigurer configurer :
@@ -307,6 +311,8 @@ private static void setDefineClassHandler() {
     DefineClassHelper.internalSetHandler(DefineClassHandler.INSTANCE);
   }
 
+  // Need to call deprecated API for backward compatibility with extensions that haven't migrated
+  @SuppressWarnings("deprecation")
   private static AgentBuilder configureIgnoredTypes(
       ClassLoader extensionClassLoader, AgentBuilder agentBuilder) {
     IgnoredTypesBuilderImpl builder = new IgnoredTypesBuilderImpl();

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/config/RuntimeConfigProperties.java

@@ -5,12 +5,13 @@
 
 package io.opentelemetry.javaagent.tooling.config;
 
+import io.opentelemetry.javaagent.tooling.EmptyConfigProperties;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import javax.annotation.Nullable;
 
 public final class RuntimeConfigProperties {
 
-  @Nullable private static volatile ConfigProperties instance = new EmptyConfigProperties();
+  @Nullable private static volatile ConfigProperties instance = EmptyConfigProperties.INSTANCE;
 
   public static void set(ConfigProperties configProperties) {
     instance = configProperties;

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ignore/UserExcludedClassesConfigurer.java

@@ -8,6 +8,7 @@
 import static java.util.Collections.emptyList;
 
 import com.google.auto.service.AutoService;
+import io.opentelemetry.api.GlobalOpenTelemetry;
 import io.opentelemetry.instrumentation.api.incubator.config.internal.DeclarativeConfigUtil;
 import io.opentelemetry.javaagent.extension.ignore.IgnoredTypesBuilder;
 import io.opentelemetry.javaagent.extension.ignore.IgnoredTypesConfigurer;
@@ -19,7 +20,7 @@ public class UserExcludedClassesConfigurer implements IgnoredTypesConfigurer {
   @Override
   public void configure(IgnoredTypesBuilder builder) {
     List<String> excludedClasses =
-        DeclarativeConfigUtil.getList(openTelemetry, "java", "agent", "exclude_classes")
+        DeclarativeConfigUtil.getList(GlobalOpenTelemetry.get(), "java", "agent", "exclude_classes")
             .orElse(emptyList());
     configureInternal(builder, excludedClasses);
   }

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/InstrumentationModuleInstaller.java

@@ -65,6 +65,8 @@ public InstrumentationModuleInstaller(Instrumentation instrumentation) {
     this.instrumentation = instrumentation;
   }
 
+  // Need to call deprecated API for backward compatibility with modules that haven't migrated
+  @SuppressWarnings("deprecation")
   AgentBuilder install(
       InstrumentationModule instrumentationModule, AgentBuilder parentAgentBuilder) {
     boolean defaultEnabled;