polish: removing unwanted logging statements, readmes and unwanted code remanants.

Author: vasantteja

instrumentation/kafka/kafka-connect-2.6/javaagent/README.md

@@ -11,22 +11,16 @@
 import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import java.util.List;
-import java.util.logging.Logger;
 
 @AutoService(InstrumentationModule.class)
 public class KafkaConnectInstrumentationModule extends InstrumentationModule {
 
-  private static final Logger logger =
-      Logger.getLogger(KafkaConnectInstrumentationModule.class.getName());
-
   public KafkaConnectInstrumentationModule() {
     super("kafka-connect", "kafka-connect-2.6");
-    logger.info("KafkaConnect: InstrumentationModule constructor called");
   }
 
   @Override
   public List<TypeInstrumentation> typeInstrumentations() {
-    logger.info("KafkaConnect: typeInstrumentations() called");
     return singletonList(new SinkTaskInstrumentation());
   }
 }

instrumentation/kafka/kafka-connect-2.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kafkaconnect/v2_6/KafkaConnectInstrumentationModule.java

@@ -16,61 +16,35 @@
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
 import java.util.Collection;
-import java.util.logging.Logger;
 import net.bytebuddy.asm.Advice;
 import net.bytebuddy.description.type.TypeDescription;
 import net.bytebuddy.matcher.ElementMatcher;
 import org.apache.kafka.connect.sink.SinkRecord;
 
 public class SinkTaskInstrumentation implements TypeInstrumentation {
 
-  private static final Logger logger = Logger.getLogger(SinkTaskInstrumentation.class.getName());
-
   @Override
   public ElementMatcher<TypeDescription> typeMatcher() {
-    logger.info("KafkaConnect: typeMatcher called");
     return hasSuperType(named("org.apache.kafka.connect.sink.SinkTask"));
   }
 
   @Override
   public void transform(TypeTransformer transformer) {
-    logger.info("KafkaConnect: transform() called - applying put() advice");
-
-    // Add advice to constructor to see what classes we're instrumenting
-    transformer.applyAdviceToMethod(
-        named("<init>"), SinkTaskInstrumentation.class.getName() + "$ConstructorAdvice");
-
     transformer.applyAdviceToMethod(
         named("put").and(takesArgument(0, Collection.class)).and(isPublic()),
         SinkTaskInstrumentation.class.getName() + "$SinkTaskPutAdvice");
   }
 
-  @SuppressWarnings("unused")
-  public static class ConstructorAdvice {
-
-    public static final Logger logger = Logger.getLogger(ConstructorAdvice.class.getName());
-
-    @Advice.OnMethodExit(suppress = Throwable.class)
-    public static void onExit(@Advice.This Object thiz) {
-      String className = thiz.getClass().getName();
-      logger.info("KafkaConnect: Instrumented class instantiated: " + className);
-    }
-  }
-
   @SuppressWarnings("unused")
   public static class SinkTaskPutAdvice {
 
-    public static final Logger logger = Logger.getLogger(SinkTaskPutAdvice.class.getName());
-
     @Advice.OnMethodEnter(suppress = Throwable.class)
     public static void onEnter(
         @Advice.Argument(0) Collection<SinkRecord> records,
         @Advice.Local("otelTask") KafkaConnectTask task,
         @Advice.Local("otelContext") Context context,
         @Advice.Local("otelScope") Scope scope) {
 
-      logger.info("KafkaConnect: SinkTask.put() called with " + records.size() + " records");
-
       Context parentContext = Java8BytecodeBridge.currentContext();
 
       // Extract context from first record if available
@@ -85,13 +59,11 @@ public static void onEnter(
 
       task = new KafkaConnectTask(records);
       if (!KafkaConnectSingletons.instrumenter().shouldStart(parentContext, task)) {
-        logger.info("KafkaConnect: Instrumenter shouldStart returned false");
         return;
       }
 
       context = KafkaConnectSingletons.instrumenter().start(parentContext, task);
       scope = context.makeCurrent();
-      logger.info("KafkaConnect: Started span");
     }
 
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
@@ -102,12 +74,10 @@ public static void onExit(
         @Advice.Local("otelScope") Scope scope) {
 
       if (scope == null) {
-        logger.info("KafkaConnect: Scope is null, exiting");
         return;
       }
       scope.close();
       KafkaConnectSingletons.instrumenter().end(context, task, null, throwable);
-      logger.info("KafkaConnect: Span ended");
     }
   }
 }

instrumentation/kafka/kafka-connect-2.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kafkaconnect/v2_6/SinkTaskInstrumentation.java

@@ -32,7 +32,6 @@ dependencies {
   testImplementation("org.testcontainers:kafka:1.19.7")
   implementation("io.rest-assured:rest-assured:5.5.5")
   testImplementation("org.junit.jupiter:junit-jupiter:5.10.2")
-  // Remove this duplicate line: testImplementation("org.apache.httpcomponents:httpclient:4.3")
   testImplementation("org.testcontainers:junit-jupiter")
   implementation("com.fasterxml.jackson.core:jackson-databind")
   testImplementation("com.squareup.okhttp3:okhttp:4.12.0")