Skip to content

Commit 8e449ef

Browse files
Add close to fix CWE-404 (#12908)
1 parent 51163cf commit 8e449ef

File tree

2 files changed

+5
-4
lines changed
  • instrumentation/runtime-telemetry/runtime-telemetry-java8/javaagent/src/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8
  • javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling

2 files changed

+5
-4
lines changed

instrumentation/runtime-telemetry/runtime-telemetry-java8/javaagent/src/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/JarDetails.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,10 @@ protected Properties getPom() throws IOException {
219219
return null;
220220
}
221221
Properties props = new Properties();
222-
props.load(jarFile.getInputStream(jarEntry));
223-
pom = props;
222+
try (InputStream in = jarFile.getInputStream(jarEntry)) {
223+
props.load(in);
224+
pom = props;
225+
}
224226
}
225227
}
226228
return pom;

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/ExtensionClassLoader.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@ public static ClassLoader getInstance(
7777
}
7878

7979
private static void includeEmbeddedExtensionsIfFound(List<URL> extensions, File javaagentFile) {
80-
try {
81-
JarFile jarFile = new JarFile(javaagentFile, false);
80+
try (JarFile jarFile = new JarFile(javaagentFile, false)) {
8281
Enumeration<JarEntry> entryEnumeration = jarFile.entries();
8382
String prefix = "extensions/";
8483
File tempDirectory = null;

0 commit comments

Comments
 (0)