Skip to content

Commit 92583fc

Browse files
committed
Address comment problems
1 parent 37808d7 commit 92583fc

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

instrumentation/apache-dubbo-2.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachedubbo/v2_7/OpenTelemetryClientFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import org.apache.dubbo.rpc.Result;
1818

1919
@Activate(group = {"consumer"})
20-
public class OpenTelemetryClientFilter implements Filter {
20+
public final class OpenTelemetryClientFilter implements Filter {
2121

2222
private final Filter delegate;
2323

instrumentation/apache-dubbo-2.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachedubbo/v2_7/OpenTelemetryServerFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import org.apache.dubbo.rpc.Result;
1818

1919
@Activate(group = {"provider"})
20-
public class OpenTelemetryServerFilter implements Filter {
20+
public final class OpenTelemetryServerFilter implements Filter {
2121

2222
private final Filter delegate;
2323

instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTelemetry.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@
1313
/** Entrypoint for instrumenting Apache Dubbo servers and clients. */
1414
public final class DubboTelemetry {
1515

16+
private final Instrumenter<DubboRequest, Result> serverInstrumenter;
17+
private final Instrumenter<DubboRequest, Result> clientInstrumenter;
18+
1619
/** Returns a new {@link DubboTelemetry} configured with the given {@link OpenTelemetry}. */
1720
public static DubboTelemetry create(OpenTelemetry openTelemetry) {
1821
return builder(openTelemetry).build();
@@ -25,10 +28,6 @@ public static DubboTelemetryBuilder builder(OpenTelemetry openTelemetry) {
2528
return new DubboTelemetryBuilder(openTelemetry);
2629
}
2730

28-
private final Instrumenter<DubboRequest, Result> serverInstrumenter;
29-
30-
private final Instrumenter<DubboRequest, Result> clientInstrumenter;
31-
3231
DubboTelemetry(
3332
Instrumenter<DubboRequest, Result> serverInstrumenter,
3433
Instrumenter<DubboRequest, Result> clientInstrumenter) {

0 commit comments

Comments
 (0)