fix

laurit · laurit · commit 939c2176e787 · 2025-07-25T13:10:26.000+03:00
diff --git a/instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/ApacheHttpClientTest.java b/instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/ApacheHttpClientTest.java
@@ -211,7 +211,7 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
   private static class HttpResponseHandler implements ResponseHandler<Void> {
     private final HttpClientResult requestResult;
 
-    public HttpResponseHandler(HttpClientResult requestResult) {
+    HttpResponseHandler(HttpClientResult requestResult) {
       this.requestResult = requestResult;
     }
 
diff --git a/instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpAsyncClientTest.java b/instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpAsyncClientTest.java
@@ -127,7 +127,7 @@ void executeRequestWithCallback(SimpleHttpRequest request, URI uri, HttpClientRe
   private static class ResponseCallback implements FutureCallback<SimpleHttpResponse> {
     private final HttpClientResult httpClientResult;
 
-    public ResponseCallback(HttpClientResult httpClientResult) {
+    ResponseCallback(HttpClientResult httpClientResult) {
       this.httpClientResult = httpClientResult;
     }
 
diff --git a/instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpClientTest.java b/instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpClientTest.java
@@ -234,7 +234,7 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
   private static class ResponseHandler implements HttpClientResponseHandler<Void> {
     private final HttpClientResult httpClientResult;
 
-    public ResponseHandler(HttpClientResult httpClientResult) {
+    ResponseHandler(HttpClientResult httpClientResult) {
       this.httpClientResult = httpClientResult;
     }
 
diff --git a/instrumentation/aws-lambda/aws-lambda-events-2.2/library/src/test/java/io/opentelemetry/instrumentation/awslambdaevents/v2_2/AwsLambdaWrapperTest.java b/instrumentation/aws-lambda/aws-lambda-events-2.2/library/src/test/java/io/opentelemetry/instrumentation/awslambdaevents/v2_2/AwsLambdaWrapperTest.java
@@ -177,8 +177,7 @@ public String handleRequest(Integer input, Context context) {
     }
   }
 
-  @SuppressWarnings("UnusedMethod")
-  private static class CustomType {
+  static class CustomType {
     String key;
     String value;
 
diff --git a/instrumentation/camel-2.20/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachecamel/aws/SnsCamelTest.java b/instrumentation/camel-2.20/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachecamel/aws/SnsCamelTest.java
@@ -174,7 +174,7 @@ private static final class SnsMetadata {
     private final String queueUrl;
     private final String topicArn;
 
-    public SnsMetadata(String queueUrl, String topicArn) {
+    SnsMetadata(String queueUrl, String topicArn) {
       this.queueUrl = queueUrl;
       this.topicArn = topicArn;
     }
diff --git a/instrumentation/cassandra/cassandra-3.0/javaagent/src/test/java/CassandraClientTest.java b/instrumentation/cassandra/cassandra-3.0/javaagent/src/test/java/CassandraClientTest.java
@@ -340,14 +340,14 @@ private static Stream<Arguments> provideAsyncParameters() {
   }
 
   private static class Parameter {
-    public final String keyspace;
-    public final String statement;
-    public final String expectedStatement;
-    public final String spanName;
-    public final String operation;
-    public final String table;
+    final String keyspace;
+    final String statement;
+    final String expectedStatement;
+    final String spanName;
+    final String operation;
+    final String table;
 
-    public Parameter(
+    Parameter(
         String keyspace,
         String statement,
         String expectedStatement,
diff --git a/instrumentation/couchbase/couchbase-2-common/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/couchbase/v2_0/CouchbaseQuerySanitizerTest.java b/instrumentation/couchbase/couchbase-2-common/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/couchbase/v2_0/CouchbaseQuerySanitizerTest.java
@@ -72,10 +72,10 @@ private static Stream<Arguments> providesArguments() {
   }
 
   private static class Parameter {
-    public final Object query;
-    public final String expected;
+    final Object query;
+    final String expected;
 
-    public Parameter(Object query, String expected) {
+    Parameter(Object query, String expected) {
       this.query = query;
       this.expected = expected;
     }
diff --git a/instrumentation/elasticsearch/elasticsearch-api-client-7.16/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/apiclient/ElasticsearchClientTest.java b/instrumentation/elasticsearch/elasticsearch-api-client-7.16/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/apiclient/ElasticsearchClientTest.java
@@ -212,19 +212,19 @@ void elasticsearchStatusAsync() throws Exception {
   }
 
   private static class AsyncRequest {
-    volatile InfoResponse response = null;
+    private volatile InfoResponse response = null;
 
-    public InfoResponse getResponse() {
+    InfoResponse getResponse() {
       return response;
     }
 
-    public void setResponse(InfoResponse response) {
+    void setResponse(InfoResponse response) {
       this.response = response;
     }
   }
 
-  private static class Person {
-    public final String name;
+  static class Person {
+    private final String name;
 
     Person(String name) {
       this.name = name;
diff --git a/instrumentation/elasticsearch/elasticsearch-rest-7.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Test.java b/instrumentation/elasticsearch/elasticsearch-rest-7.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Test.java
@@ -183,22 +183,22 @@ public void onFailure(Exception e) {
   }
 
   private static class AsyncRequest {
-    volatile Response requestResponse = null;
-    volatile Exception exception = null;
+    private volatile Response requestResponse = null;
+    private volatile Exception exception = null;
 
-    public Response getRequestResponse() {
+    Response getRequestResponse() {
       return requestResponse;
     }
 
-    public void setRequestResponse(Response requestResponse) {
+    void setRequestResponse(Response requestResponse) {
       this.requestResponse = requestResponse;
     }
 
-    public Exception getException() {
+    Exception getException() {
       return exception;
     }
 
-    public void setException(Exception exception) {
+    void setException(Exception exception) {
       this.exception = exception;
     }
   }
diff --git a/instrumentation/elasticsearch/elasticsearch-rest-7.0/library/src/test/java/io/opentelemetry/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Test.java b/instrumentation/elasticsearch/elasticsearch-rest-7.0/library/src/test/java/io/opentelemetry/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7Test.java
@@ -159,22 +159,22 @@ public void onFailure(Exception e) {
   }
 
   private static class AsyncRequest {
-    volatile Response requestResponse = null;
-    volatile Exception exception = null;
+    private volatile Response requestResponse = null;
+    private volatile Exception exception = null;
 
-    public Response getRequestResponse() {
+    Response getRequestResponse() {
       return requestResponse;
     }
 
-    public void setRequestResponse(Response requestResponse) {
+    void setRequestResponse(Response requestResponse) {
       this.requestResponse = requestResponse;
     }
 
-    public Exception getException() {
+    Exception getException() {
       return exception;
     }
 
-    public void setException(Exception exception) {
+    void setException(Exception exception) {
       this.exception = exception;
     }
   }
diff --git a/instrumentation/elasticsearch/elasticsearch-transport-6.0/javaagent/src/elasticsearch6Test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/Elasticsearch6NodeFactory.java b/instrumentation/elasticsearch/elasticsearch-transport-6.0/javaagent/src/elasticsearch6Test/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/transport/v6_0/Elasticsearch6NodeFactory.java
@@ -18,7 +18,7 @@ public Node newNode(Settings settings) {
         InternalSettingsPreparer.prepareEnvironment(settings, null),
         Collections.singleton(Netty4Plugin.class)) {
 
-      @SuppressWarnings({"UnusedMethod", "UnusedVariable"})
+      @SuppressWarnings({"UnusedMethod", "UnusedVariable", "EffectivelyPrivate"})
       protected void registerDerivedNodeNameWithLogger(String s) {}
     };
   }
diff --git a/instrumentation/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTest.java b/instrumentation/grpc-1.6/library/src/test/java/io/opentelemetry/instrumentation/grpc/v1_6/GrpcTest.java
@@ -176,7 +176,7 @@ private static class CustomAttributesExtractorV2
 
     private final String valueOfKey2;
 
-    public CustomAttributesExtractorV2(String valueOfKey2) {
+    CustomAttributesExtractorV2(String valueOfKey2) {
       this.valueOfKey2 = valueOfKey2;
     }
 
diff --git a/instrumentation/hibernate/hibernate-3.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v3_3/QueryTest.java b/instrumentation/hibernate/hibernate-3.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v3_3/QueryTest.java
@@ -140,11 +140,11 @@ private static Stream<Arguments> provideArguments() {
   }
 
   private static class Parameter {
-    public final String expectedSpanName;
-    public final boolean requiresTransaction;
-    public final Consumer<Session> queryInteraction;
+    final String expectedSpanName;
+    final boolean requiresTransaction;
+    final Consumer<Session> queryInteraction;
 
-    public Parameter(
+    Parameter(
         String expectedSpanName, boolean requiresTransaction, Consumer<Session> queryInteraction) {
       this.expectedSpanName = expectedSpanName;
       this.requiresTransaction = requiresTransaction;
diff --git a/instrumentation/hibernate/hibernate-3.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v3_3/SessionTest.java b/instrumentation/hibernate/hibernate-3.3/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v3_3/SessionTest.java
@@ -576,13 +576,13 @@ private static Stream<Arguments> provideArgumentsForQueryMethods() {
   }
 
   private static class Parameter {
-    public final String methodName;
-    public final String resource;
-    public final BiConsumer<Session, Value> sessionMethodTest;
-    public final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
-    public final Function<Session, Query> queryBuildMethod;
+    final String methodName;
+    final String resource;
+    final BiConsumer<Session, Value> sessionMethodTest;
+    final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
+    final Function<Session, Query> queryBuildMethod;
 
-    public Parameter(
+    Parameter(
         String methodName,
         String resource,
         BiConsumer<Session, Value> sessionMethodTest,
diff --git a/instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/EntityManagerTest.java b/instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/EntityManagerTest.java
@@ -371,12 +371,12 @@ private static Stream<Arguments> provideArgumentsAttachesState() {
   }
 
   private static class Parameter {
-    public final String methodName;
-    public final boolean attach;
-    public final boolean flushOnCommit;
-    public final BiConsumer<EntityManager, Value> sessionMethodTest;
+    final String methodName;
+    final boolean attach;
+    final boolean flushOnCommit;
+    final BiConsumer<EntityManager, Value> sessionMethodTest;
 
-    public Parameter(
+    Parameter(
         String methodName,
         boolean attach,
         boolean flushOnCommit,
diff --git a/instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/QueryTest.java b/instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/QueryTest.java
@@ -225,10 +225,10 @@ void testHibernateQueryIterate() {
   }
 
   private static class Parameter {
-    public final String expectedSpanName;
-    public final Consumer<Session> queryInteraction;
+    final String expectedSpanName;
+    final Consumer<Session> queryInteraction;
 
-    public Parameter(String expectedSpanName, Consumer<Session> queryInteraction) {
+    Parameter(String expectedSpanName, Consumer<Session> queryInteraction) {
       this.expectedSpanName = expectedSpanName;
       this.queryInteraction = queryInteraction;
     }
diff --git a/instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/SessionTest.java b/instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/SessionTest.java
@@ -851,11 +851,11 @@ void testHibernateOverlappingSessions() {
   }
 
   private static class Parameter {
-    public final String methodName;
-    public final BiConsumer<Session, Value> sessionMethodTest;
-    public final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
+    final String methodName;
+    final BiConsumer<Session, Value> sessionMethodTest;
+    final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
 
-    public Parameter(
+    Parameter(
         String methodName,
         BiConsumer<Session, Value> sessionMethodTest,
         BiConsumer<StatelessSession, Value> statelessSessionMethodTest) {
diff --git a/instrumentation/hibernate/hibernate-6.0/javaagent/src/hibernate6Test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v6_0/SessionTest.java b/instrumentation/hibernate/hibernate-6.0/javaagent/src/hibernate6Test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v6_0/SessionTest.java
@@ -773,6 +773,12 @@ private static Stream<Arguments> provideAttachesStateToQueryParameters() {
   }
 
   private static class Parameter {
+    final String methodName;
+    final String resource;
+    final Function<Session, SelectionQuery<?>> queryBuildMethod;
+    final BiConsumer<Session, Value> sessionMethodTest;
+    final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
+
     Parameter(
         String methodName,
         String resource,
@@ -785,12 +791,6 @@ private static class Parameter {
       this.queryBuildMethod = queryBuildMethod;
       this.statelessSessionMethodTest = statelessSessionMethodTest;
     }
-
-    public final String methodName;
-    public final String resource;
-    public final Function<Session, SelectionQuery<?>> queryBuildMethod;
-    public final BiConsumer<Session, Value> sessionMethodTest;
-    public final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
   }
 
   private static SpanDataAssert assertSessionSpan(
diff --git a/instrumentation/hibernate/hibernate-6.0/javaagent/src/hibernate7Test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v7_0/SessionTest.java b/instrumentation/hibernate/hibernate-6.0/javaagent/src/hibernate7Test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v7_0/SessionTest.java
@@ -683,6 +683,12 @@ private static Stream<Arguments> provideAttachesStateToQueryParameters() {
   }
 
   private static class Parameter {
+    final String methodName;
+    final String resource;
+    final Function<Session, SelectionQuery<?>> queryBuildMethod;
+    final BiConsumer<Session, Value> sessionMethodTest;
+    final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
+
     Parameter(
         String methodName,
         String resource,
@@ -695,12 +701,6 @@ private static class Parameter {
       this.queryBuildMethod = queryBuildMethod;
       this.statelessSessionMethodTest = statelessSessionMethodTest;
     }
-
-    public final String methodName;
-    public final String resource;
-    public final Function<Session, SelectionQuery<?>> queryBuildMethod;
-    public final BiConsumer<Session, Value> sessionMethodTest;
-    public final BiConsumer<StatelessSession, Value> statelessSessionMethodTest;
   }
 
   private static SpanDataAssert assertSessionSpan(
diff --git a/instrumentation/hibernate/hibernate-6.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v6_0/EntityManagerTest.java b/instrumentation/hibernate/hibernate-6.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v6_0/EntityManagerTest.java
@@ -294,6 +294,12 @@ private static Stream<Arguments> provideAttachesStateParameters() {
   }
 
   private static class Parameter {
+    final String methodName;
+    final String resource;
+    final boolean attach;
+    final boolean flushOnCommit;
+    final BiConsumer<EntityManager, Value> sessionMethodTest;
+    final Function<EntityManager, Query> queryBuildMethod;
 
     Parameter(String methodName, String resource, Function<EntityManager, Query> queryBuildMethod) {
       this.methodName = methodName;
@@ -317,13 +323,6 @@ private static class Parameter {
       this.sessionMethodTest = sessionMethodTest;
       this.queryBuildMethod = null;
     }
-
-    public final String methodName;
-    public final String resource;
-    public final boolean attach;
-    public final boolean flushOnCommit;
-    public final BiConsumer<EntityManager, Value> sessionMethodTest;
-    public final Function<EntityManager, Query> queryBuildMethod;
   }
 
   @SuppressWarnings("deprecation") // TODO DB_CONNECTION_STRING deprecation
diff --git a/instrumentation/hystrix-1.4/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hystrix/HystrixObservableChainTest.java b/instrumentation/hystrix-1.4/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hystrix/HystrixObservableChainTest.java
@@ -31,7 +31,7 @@ class HystrixObservableChainTest {
   void testCommand() {
 
     class TestCommand extends HystrixObservableCommand<String> {
-      protected TestCommand(Setter setter) {
+      TestCommand(Setter setter) {
         super(setter);
       }
 
@@ -50,7 +50,7 @@ protected Observable<String> construct() {
     class AnotherTestCommand extends HystrixObservableCommand<String> {
       private final String str;
 
-      protected AnotherTestCommand(Setter setter, String str) {
+      AnotherTestCommand(Setter setter, String str) {
         super(setter);
         this.str = str;
       }
diff --git a/instrumentation/hystrix-1.4/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hystrix/HystrixObservableTest.java b/instrumentation/hystrix-1.4/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hystrix/HystrixObservableTest.java
diff --git a/instrumentation/hystrix-1.4/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hystrix/HystrixTest.java b/instrumentation/hystrix-1.4/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hystrix/HystrixTest.java
diff --git a/instrumentation/lettuce/lettuce-common/library/src/test/java/io/opentelemetry/instrumentation/lettuce/common/LettuceArgSplitterTest.java b/instrumentation/lettuce/lettuce-common/library/src/test/java/io/opentelemetry/instrumentation/lettuce/common/LettuceArgSplitterTest.java
diff --git a/instrumentation/resources/library/src/test/java/io/opentelemetry/instrumentation/resources/ManifestResourceProviderTest.java b/instrumentation/resources/library/src/test/java/io/opentelemetry/instrumentation/resources/ManifestResourceProviderTest.java
diff --git a/instrumentation/servlet/servlet-3.0/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/snippet/SnippetServletOutputStreamTest.java b/instrumentation/servlet/servlet-3.0/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/snippet/SnippetServletOutputStreamTest.java
diff --git a/instrumentation/servlet/servlet-5.0/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v5_0/snippet/SnippetServletOutputStreamTest.java b/instrumentation/servlet/servlet-5.0/javaagent-unit-tests/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v5_0/snippet/SnippetServletOutputStreamTest.java
diff --git a/instrumentation/spring/spring-webflux/spring-webflux-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/webflux/v5_0/server/SpringWebfluxTest.java b/instrumentation/spring/spring-webflux/spring-webflux-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/webflux/v5_0/server/SpringWebfluxTest.java
diff --git a/javaagent-tooling/src/testMissingType/java/io/opentelemetry/javaagent/tooling/bytebuddy/MissingTypeTest.java b/javaagent-tooling/src/testMissingType/java/io/opentelemetry/javaagent/tooling/bytebuddy/MissingTypeTest.java
diff --git a/smoke-tests/src/test/java/io/opentelemetry/smoketest/windows/WindowsTestContainerManager.java b/smoke-tests/src/test/java/io/opentelemetry/smoketest/windows/WindowsTestContainerManager.java

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {`
`211`	`211`	`private static class HttpResponseHandler implements ResponseHandler<Void> {`
`212`	`212`	`private final HttpClientResult requestResult;`
`213`	`213`
`214`		`- public HttpResponseHandler(HttpClientResult requestResult) {`
	`214`	`+ HttpResponseHandler(HttpClientResult requestResult) {`
`215`	`215`	`this.requestResult = requestResult;`
`216`	`216`	`}`
`217`	`217`
Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ void executeRequestWithCallback(SimpleHttpRequest request, URI uri, HttpClientRe`
`127`	`127`	`private static class ResponseCallback implements FutureCallback<SimpleHttpResponse> {`
`128`	`128`	`private final HttpClientResult httpClientResult;`
`129`	`129`
`130`		`- public ResponseCallback(HttpClientResult httpClientResult) {`
	`130`	`+ ResponseCallback(HttpClientResult httpClientResult) {`
`131`	`131`	`this.httpClientResult = httpClientResult;`
`132`	`132`	`}`
`133`	`133`
Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {`
`234`	`234`	`private static class ResponseHandler implements HttpClientResponseHandler<Void> {`
`235`	`235`	`private final HttpClientResult httpClientResult;`
`236`	`236`
`237`		`- public ResponseHandler(HttpClientResult httpClientResult) {`
	`237`	`+ ResponseHandler(HttpClientResult httpClientResult) {`
`238`	`238`	`this.httpClientResult = httpClientResult;`
`239`	`239`	`}`
`240`	`240`
Original file line number	Diff line number	Diff line change
`@@ -177,8 +177,7 @@ public String handleRequest(Integer input, Context context) {`
`177`	`177`	`}`
`178`	`178`	`}`
`179`	`179`
`180`		`- @SuppressWarnings("UnusedMethod")`
`181`		`- private static class CustomType {`
	`180`	`+ static class CustomType {`
`182`	`181`	`String key;`
`183`	`182`	`String value;`
`184`	`183`
Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ private static final class SnsMetadata {`
`174`	`174`	`private final String queueUrl;`
`175`	`175`	`private final String topicArn;`
`176`	`176`
`177`		`- public SnsMetadata(String queueUrl, String topicArn) {`
	`177`	`+ SnsMetadata(String queueUrl, String topicArn) {`
`178`	`178`	`this.queueUrl = queueUrl;`
`179`	`179`	`this.topicArn = topicArn;`
`180`	`180`	`}`
Original file line number	Diff line number	Diff line change
`@@ -72,10 +72,10 @@ private static Stream<Arguments> providesArguments() {`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`private static class Parameter {`
`75`		`- public final Object query;`
`76`		`- public final String expected;`
	`75`	`+ final Object query;`
	`76`	`+ final String expected;`
`77`	`77`
`78`		`- public Parameter(Object query, String expected) {`
	`78`	`+ Parameter(Object query, String expected) {`
`79`	`79`	`this.query = query;`
`80`	`80`	`this.expected = expected;`
`81`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -212,19 +212,19 @@ void elasticsearchStatusAsync() throws Exception {`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`private static class AsyncRequest {`
`215`		`- volatile InfoResponse response = null;`
	`215`	`+ private volatile InfoResponse response = null;`
`216`	`216`
`217`		`- public InfoResponse getResponse() {`
	`217`	`+ InfoResponse getResponse() {`
`218`	`218`	`return response;`
`219`	`219`	`}`
`220`	`220`
`221`		`- public void setResponse(InfoResponse response) {`
	`221`	`+ void setResponse(InfoResponse response) {`
`222`	`222`	`this.response = response;`
`223`	`223`	`}`
`224`	`224`	`}`
`225`	`225`
`226`		`- private static class Person {`
`227`		`- public final String name;`
	`226`	`+ static class Person {`
	`227`	`+ private final String name;`
`228`	`228`
`229`	`229`	`Person(String name) {`
`230`	`230`	`this.name = name;`
Original file line number	Diff line number	Diff line change
`@@ -183,22 +183,22 @@ public void onFailure(Exception e) {`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`private static class AsyncRequest {`
`186`		`- volatile Response requestResponse = null;`
`187`		`- volatile Exception exception = null;`
	`186`	`+ private volatile Response requestResponse = null;`
	`187`	`+ private volatile Exception exception = null;`
`188`	`188`
`189`		`- public Response getRequestResponse() {`
	`189`	`+ Response getRequestResponse() {`
`190`	`190`	`return requestResponse;`
`191`	`191`	`}`
`192`	`192`
`193`		`- public void setRequestResponse(Response requestResponse) {`
	`193`	`+ void setRequestResponse(Response requestResponse) {`
`194`	`194`	`this.requestResponse = requestResponse;`
`195`	`195`	`}`
`196`	`196`
`197`		`- public Exception getException() {`
	`197`	`+ Exception getException() {`
`198`	`198`	`return exception;`
`199`	`199`	`}`
`200`	`200`
`201`		`- public void setException(Exception exception) {`
	`201`	`+ void setException(Exception exception) {`
`202`	`202`	`this.exception = exception;`
`203`	`203`	`}`
`204`	`204`	`}`
Original file line number	Diff line number	Diff line change
`@@ -159,22 +159,22 @@ public void onFailure(Exception e) {`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`private static class AsyncRequest {`
`162`		`- volatile Response requestResponse = null;`
`163`		`- volatile Exception exception = null;`
	`162`	`+ private volatile Response requestResponse = null;`
	`163`	`+ private volatile Exception exception = null;`
`164`	`164`
`165`		`- public Response getRequestResponse() {`
	`165`	`+ Response getRequestResponse() {`
`166`	`166`	`return requestResponse;`
`167`	`167`	`}`
`168`	`168`
`169`		`- public void setRequestResponse(Response requestResponse) {`
	`169`	`+ void setRequestResponse(Response requestResponse) {`
`170`	`170`	`this.requestResponse = requestResponse;`
`171`	`171`	`}`
`172`	`172`
`173`		`- public Exception getException() {`
	`173`	`+ Exception getException() {`
`174`	`174`	`return exception;`
`175`	`175`	`}`
`176`	`176`
`177`		`- public void setException(Exception exception) {`
	`177`	`+ void setException(Exception exception) {`
`178`	`178`	`this.exception = exception;`
`179`	`179`	`}`
`180`	`180`	`}`