Skip to content

Commit 943d693

Browse files
committed
second try
1 parent a7b082d commit 943d693

File tree

2 files changed

+3
-7
lines changed
  • instrumentation/hibernate/hibernate-6.0/javaagent

2 files changed

+3
-7
lines changed

instrumentation/hibernate/hibernate-6.0/javaagent/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,6 @@ tasks {
6969
withType<Test>().configureEach {
7070
// TODO run tests both with and without experimental span attributes
7171
jvmArgs("-Dotel.instrumentation.hibernate.experimental-span-attributes=true")
72-
73-
systemProperty("testLatestDeps", findProperty("testLatestDeps") as Boolean)
7472
}
7573

7674
named("compileHibernate7TestJava", JavaCompile::class).configure {

instrumentation/hibernate/hibernate-6.0/javaagent/src/hibernate7Test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v7_0/SessionTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,15 @@ class SessionTest extends AbstractHibernateTest {
5252
@MethodSource("provideHibernateActionParameters")
5353
void testHibernateAction(Parameter parameter) {
5454
Session session = sessionFactory.openSession();
55+
session.beginTransaction();
56+
5557
Value value = session.merge(prepopulated.get(0));
5658
testing.waitForTraces(1);
5759
testing.clearData();
5860

5961
testing.runWithSpan(
6062
"parent",
6163
() -> {
62-
session.beginTransaction();
6364
try {
6465
parameter.sessionMethodTest.accept(session, value);
6566
} catch (RuntimeException e) {
@@ -68,10 +69,7 @@ void testHibernateAction(Parameter parameter) {
6869
session.getTransaction().commit();
6970
session.close();
7071
});
71-
assertTraces(
72-
parameter,
73-
"refresh".equals(parameter.methodName)
74-
|| (Boolean.getBoolean("testLatestDeps") && "lock".equals(parameter.methodName)));
72+
assertTraces(parameter, "refresh".equals(parameter.methodName));
7573
}
7674

7775
@ParameterizedTest(name = "{index}: {0}")

0 commit comments

Comments
 (0)