finish implementing unit test

Author: ghareeb-falazi

instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergMetricsReporter.java

@@ -10,6 +10,7 @@
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.metrics.LongCounter;
 import io.opentelemetry.api.metrics.LongGauge;
+import java.util.Locale;
 import org.apache.iceberg.metrics.CommitMetricsResult;
 import org.apache.iceberg.metrics.CommitReport;
 import org.apache.iceberg.metrics.CounterResult;
@@ -57,7 +58,9 @@ void reportScanMetrics(ScanReport scanReport) {
 
     if (duration != null) {
       LongGauge metric =
-          ScanMetricsBuilder.totalPlanningDuration(openTelemetry.getMeter(INSTRUMENTATION_NAME));
+          ScanMetricsBuilder.totalPlanningDuration(
+              openTelemetry.getMeter(INSTRUMENTATION_NAME),
+              duration.timeUnit().name().toLowerCase(Locale.getDefault()));
       metric.set(duration.totalDuration().toMillis(), scanAttributes);
     }
 

instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergTelemetry.java

@@ -5,12 +5,11 @@
 
 package io.opentelemetry.instrumentation.iceberg.v1_8;
 
+import io.opentelemetry.api.OpenTelemetry;
 import org.apache.iceberg.Scan;
 import org.apache.iceberg.ScanTask;
 import org.apache.iceberg.ScanTaskGroup;
 
-import io.opentelemetry.api.OpenTelemetry;
-
 public class IcebergTelemetry {
   private final OpenTelemetry openTelemetry;
 
@@ -22,7 +21,8 @@ public static IcebergTelemetry create(OpenTelemetry openTelemetry) {
     this.openTelemetry = openTelemetry;
   }
 
-  public <ThisT, T extends ScanTask, G extends ScanTaskGroup<T>> ThisT wrapScan(Scan<ThisT, T, G> scan) {
+  public <ThisT, T extends ScanTask, G extends ScanTaskGroup<T>> ThisT wrapScan(
+      Scan<ThisT, T, G> scan) {
     return scan.metricsReporter(new IcebergMetricsReporter(openTelemetry));
   }
 }

instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/ScanMetricsBuilder.java

@@ -19,7 +19,7 @@ final class ScanMetricsBuilder {
   private static final String TOTAL_DATA_MANIFESTS = ROOT + ".total.data_manifests.count";
   private static final String TOTAL_DELETE_MANIFESTS = ROOT + ".total.delete_manifests.count";
   private static final String TOTAL_FILE_SIZE_IN_BYTES = ROOT + ".scanned.data_files.size";
-  private static final String TOTAL_DELETE_FILE_SIZE_IN_BYTES = ROOT + "scanned.delete_files.size";
+  private static final String TOTAL_DELETE_FILE_SIZE_IN_BYTES = ROOT + ".scanned.delete_files.size";
   private static final String SKIPPED_DATA_MANIFESTS = ROOT + ".skipped.data_manifests.count";
   private static final String SKIPPED_DELETE_MANIFESTS = ROOT + ".skipped.delete_manifests.count";
   private static final String SKIPPED_DATA_FILES = ROOT + ".skipped.data_files.count";
@@ -34,11 +34,11 @@ private ScanMetricsBuilder() {
     // prevents instantiation
   }
 
-  static LongGauge totalPlanningDuration(Meter meter) {
+  static LongGauge totalPlanningDuration(Meter meter, String unit) {
     return meter
         .gaugeBuilder(TOTAL_PLANNING_DURATION)
         .setDescription("The total duration needed to plan the scan.")
-        .setUnit("ms")
+        .setUnit(unit)
         .ofLongs()
         .build();
   }

instrumentation/iceberg-1.8/library/src/test/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergLibraryTest.java

@@ -1,11 +1,15 @@
-package io.opentelemetry.instrumentation.iceberg.v1_8;
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
 
-import org.apache.iceberg.TableScan;
-import org.junit.jupiter.api.extension.RegisterExtension;
+package io.opentelemetry.instrumentation.iceberg.v1_8;
 
 import io.opentelemetry.api.OpenTelemetry;
 import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
 import io.opentelemetry.instrumentation.testing.junit.LibraryInstrumentationExtension;
+import org.apache.iceberg.TableScan;
+import org.junit.jupiter.api.extension.RegisterExtension;
 
 public class IcebergLibraryTest extends AbstractIcebergTest {
   @RegisterExtension

instrumentation/iceberg-1.8/testing/build.gradle.kts

@@ -11,4 +11,4 @@ dependencies {
   }
   implementation("org.apache.commons:commons-compress:1.26.2")
   api(project(":testing-common"))
-}
+}