Skip to content

Commit 9809568

Browse files
committed
fix minor things and comments
1 parent 414c367 commit 9809568

File tree

2 files changed

+3
-3
lines changed
  • instrumentation
    • opentelemetry-extension-annotations-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/extensionannotations
    • opentelemetry-instrumentation-annotations-1.16/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/instrumentationannotations

2 files changed

+3
-3
lines changed

instrumentation/opentelemetry-extension-annotations-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/extensionannotations/WithSpanInstrumentation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public Object end(Object returnValue, @Nullable Throwable throwable) {
155155
@Advice.OnMethodEnter(suppress = Throwable.class)
156156
public static WithSpanAdviceScope onEnter(@Advice.Origin Method originMethod) {
157157
// Every usage of @Advice.Origin Method is replaced with a call to Class.getMethod, copy it
158-
// to local variable so that there would be only one call to Class.getMethod.
158+
// to advice scope so that there would be only one call to Class.getMethod.
159159
return WithSpanAdviceScope.start(originMethod);
160160
}
161161

@@ -217,7 +217,7 @@ public static WithSpanAttributesAdviceScope onEnter(
217217
@Advice.Origin Method originMethod,
218218
@Advice.AllArguments(typing = Assigner.Typing.DYNAMIC) Object[] args) {
219219
// Every usage of @Advice.Origin Method is replaced with a call to Class.getMethod, copy it
220-
// to local variable so that there would be only one call to Class.getMethod.
220+
// to advice scope so that there would be only one call to Class.getMethod.
221221
MethodRequest request = new MethodRequest(originMethod, args);
222222
return WithSpanAttributesAdviceScope.start(originMethod, request);
223223
}

instrumentation/opentelemetry-instrumentation-annotations-1.16/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/instrumentationannotations/WithSpanInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public static class WithSpanAdviceScope {
8787
private final Context context;
8888
private final Scope scope;
8989

90-
public WithSpanAdviceScope(Method method, Context context, Scope scope) {
90+
private WithSpanAdviceScope(Method method, Context context, Scope scope) {
9191
this.method = method;
9292
this.context = context;
9393
this.scope = scope;

0 commit comments

Comments
 (0)