Skip to content

Commit 9c6f987

Browse files
committed
micrometer fix
1 parent f100658 commit 9c6f987

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

instrumentation/spring/spring-boot-autoconfigure/build.gradle.kts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ dependencies {
132132
add("javaSpring4CompileOnly", project(":instrumentation:kafka:kafka-clients:kafka-clients-2.6:library"))
133133
add("javaSpring4CompileOnly", project(":instrumentation:spring:spring-kafka-2.7:library"))
134134
add("javaSpring4CompileOnly", project(":instrumentation:mongo:mongo-3.1:library"))
135+
add("javaSpring4CompileOnly", project(":instrumentation:micrometer:micrometer-1.5:library"))
135136
}
136137

137138
val latestDepTest = findProperty("testLatestDeps") as Boolean
@@ -208,9 +209,11 @@ testing {
208209
implementation("org.springframework.boot:spring-boot-starter-kafka:4.0.0")
209210
implementation("org.springframework.boot:spring-boot-starter-actuator:4.0.0")
210211
implementation("org.springframework.boot:spring-boot-starter-data-r2dbc:4.0.0")
212+
implementation("org.springframework.boot:spring-boot-starter-micrometer-metrics:4.0.0")
211213
implementation("io.opentelemetry:opentelemetry-sdk")
212214
implementation("io.opentelemetry:opentelemetry-sdk-testing")
213215
implementation(project(":instrumentation-api"))
216+
implementation(project(":instrumentation:micrometer:micrometer-1.5:library"))
214217
implementation("org.springframework.boot:spring-boot-starter-test:4.0.0") {
215218
exclude("org.junit.vintage", "junit-vintage-engine")
216219
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
import io.opentelemetry.instrumentation.micrometer.v1_5.OpenTelemetryMeterRegistry;
1212
import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration;
1313
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.ConditionalOnEnabledInstrumentation;
14-
import org.springframework.boot.actuate.autoconfigure.metrics.CompositeMeterRegistryAutoConfiguration;
15-
import org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration;
1614
import org.springframework.boot.autoconfigure.AutoConfigureAfter;
1715
import org.springframework.boot.autoconfigure.AutoConfigureBefore;
1816
import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
1917
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
18+
import org.springframework.boot.micrometer.metrics.autoconfigure.CompositeMeterRegistryAutoConfiguration;
19+
import org.springframework.boot.micrometer.metrics.autoconfigure.MetricsAutoConfiguration;
2020
import org.springframework.context.annotation.Bean;
2121
import org.springframework.context.annotation.Configuration;
2222

@@ -30,7 +30,7 @@
3030
@ConditionalOnBean(Clock.class)
3131
@ConditionalOnClass(MeterRegistry.class)
3232
@Configuration
33-
public class MicrometerBridgeAutoSpringBoot4Configuration {
33+
public class MicrometerBridgeSpringBoot4AutoConfiguration {
3434

3535
@Bean
3636
MeterRegistry otelMeterRegistry(OpenTelemetry openTelemetry, Clock micrometerClock) {

instrumentation/spring/spring-boot-autoconfigure/src/main/resources/META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.l
77
io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.jdbc.JdbcInstrumentationAutoConfiguration
88
io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.jdbc.JdbcInstrumentationSpringBoot4AutoConfiguration
99
io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.micrometer.MicrometerBridgeAutoConfiguration
10+
io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.micrometer.MicrometerBridgeSpringBoot4AutoConfiguration
1011
io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.r2dbc.R2dbcInstrumentationAutoConfiguration
1112
io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.web.SpringWebInstrumentationAutoConfiguration
1213
io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.web.SpringWebInstrumentationSpringBoot4AutoConfiguration

instrumentation/spring/spring-boot-autoconfigure/src/testSpring4/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/micrometer/MicrometerBridgeAutoConfigurationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@
1111
import io.opentelemetry.api.OpenTelemetry;
1212
import io.opentelemetry.instrumentation.micrometer.v1_5.OpenTelemetryMeterRegistry;
1313
import org.junit.jupiter.api.Test;
14-
import org.springframework.boot.actuate.autoconfigure.metrics.MetricsAutoConfiguration;
1514
import org.springframework.boot.autoconfigure.AutoConfigurations;
15+
import org.springframework.boot.micrometer.metrics.autoconfigure.MetricsAutoConfiguration;
1616
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
1717

1818
class MicrometerBridgeAutoConfigurationTest {
@@ -21,7 +21,7 @@ class MicrometerBridgeAutoConfigurationTest {
2121
new ApplicationContextRunner()
2222
.withBean(OpenTelemetry.class, OpenTelemetry::noop)
2323
.withConfiguration(
24-
AutoConfigurations.of(MicrometerBridgeAutoSpringBoot4Configuration.class));
24+
AutoConfigurations.of(MicrometerBridgeSpringBoot4AutoConfiguration.class));
2525

2626
@Test
2727
void metricsEnabled() {

instrumentation/spring/spring-boot-autoconfigure/src/testSpring4/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/r2dbc/R2DbcInstrumentationAutoConfigurationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import org.junit.jupiter.api.Test;
1818
import org.junit.jupiter.api.extension.RegisterExtension;
1919
import org.springframework.boot.autoconfigure.AutoConfigurations;
20-
import org.springframework.boot.autoconfigure.r2dbc.R2dbcAutoConfiguration;
20+
import org.springframework.boot.r2dbc.autoconfigure.R2dbcAutoConfiguration;
2121
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
2222
import org.springframework.r2dbc.core.DatabaseClient;
2323

0 commit comments

Comments
 (0)