Skip to content

Commit 9cbf610

Browse files
committed
fix rebase
1 parent 8fab4e6 commit 9cbf610

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientCommonAttributesGetter.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
package io.opentelemetry.instrumentation.api.incubator.semconv.db;
77

8-
import static java.util.Objects.requireNonNull;
9-
108
import javax.annotation.Nullable;
119

1210
/** An interface for getting attributes common to database clients. */
@@ -20,11 +18,8 @@ default String getUser(REQUEST request) {
2018
return null;
2119
}
2220

23-
// TODO: make this required to implement
2421
@Nullable
25-
default String getDbNamespace(REQUEST request) {
26-
return getName(request);
27-
}
22+
String getDbNamespace(REQUEST request);
2823

2924
@Deprecated
3025
@Nullable

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/SqlClientAttributesGetter.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55

66
package io.opentelemetry.instrumentation.api.incubator.semconv.db;
77

8-
import static java.util.Collections.emptySet;
9-
import static java.util.Collections.singleton;
10-
118
import java.util.Collection;
129
import java.util.Collections;
1310
import java.util.Map;
@@ -33,14 +30,9 @@ public interface SqlClientAttributesGetter<REQUEST, RESPONSE>
3330
* <p>If {@code request} is not a batch query, then this method should return a collection with a
3431
* single element.
3532
*/
36-
// TODO: make this required to implement
37-
default Collection<String> getRawQueryTexts(REQUEST request) {
38-
String rawQueryText = getRawQueryText(request);
39-
return rawQueryText == null ? emptySet() : singleton(rawQueryText);
40-
}
33+
Collection<String> getRawQueryTexts(REQUEST request);
4134

4235
// TODO: make this required to implement
43-
@Nullable
4436
default Long getBatchSize(REQUEST request) {
4537
return null;
4638
}

0 commit comments

Comments
 (0)