Skip to content

Commit a0c743b

Browse files
committed
Comments updated
1 parent c60c0e5 commit a0c743b

File tree

1 file changed

+4
-3
lines changed
  • instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules

1 file changed

+4
-3
lines changed

instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/HadoopTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ void testMetrics_Hadoop2x() {
2424

2525
yamlFiles.forEach(this::validateYamlSyntax);
2626

27-
// bmedora docker images do not propagate env vars to spanned hadoop processes,
28-
// so everything needs to be embedded inside the hadoop2-env.sh file
27+
28+
// Hadoop startup script does not propagate env vars to launched hadoop daemons,
29+
// so all the env vars needs to be embedded inside the hadoop-env.sh file
2930
GenericContainer<?> target =
3031
new GenericContainer<>("bmedora/hadoop:2.9-base")
3132
.withCopyFileToContainer(
@@ -51,7 +52,7 @@ void testMetrics_Hadoop3x() {
5152
yamlFiles.forEach(this::validateYamlSyntax);
5253

5354
// Hadoop startup script does not propagate env vars to launched hadoop daemons,
54-
// so all the env vars needs to be embedded inside the hadoop2-env.sh file
55+
// so all the env vars needs to be embedded inside the hadoop-env.sh file
5556
GenericContainer<?> target =
5657
new GenericContainer<>("loum/hadoop-pseudo:3.3.6")
5758
.withExposedPorts(9870, 9000)

0 commit comments

Comments
 (0)