Skip to content

Commit a185432

Browse files
zeitlingerzeitlinger
committed
add nullaway
1 parent 934d790 commit a185432

File tree

45 files changed

+87
-0
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+87
-0
lines changed

‎instrumentation/activej-http-6.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/activejhttp/ActivejHttpServerAttributesGetter.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ final class ActivejHttpServerAttributesGetter
2121
implements HttpServerAttributesGetter<HttpRequest, HttpResponse> {
2222

2323
@Override
24+
@Nullable
2425
public String getHttpRequestMethod(HttpRequest request) {
2526
return request.getMethod().name();
2627
}
@@ -59,11 +60,13 @@ public List<String> getHttpResponseHeader(
5960
}
6061

6162
@Override
63+
@Nullable
6264
public String getUrlScheme(HttpRequest request) {
6365
return request.getProtocol().lowercase();
6466
}
6567

6668
@Override
69+
@Nullable
6770
public String getUrlPath(HttpRequest request) {
6871
return request.getPath();
6972
}

‎instrumentation/akka/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/client/AkkaHttpClientAttributesGetter.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public String getUrlFull(HttpRequest httpRequest) {
2121
}
2222

2323
@Override
24+
@Nullable
2425
public String getHttpRequestMethod(HttpRequest httpRequest) {
2526
return httpRequest.method().value();
2627
}

‎instrumentation/akka/akka-http-10.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/akkahttp/server/AkkaHttpServerAttributesGetter.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ class AkkaHttpServerAttributesGetter
1717
implements HttpServerAttributesGetter<HttpRequest, HttpResponse> {
1818

1919
@Override
20+
@Nullable
2021
public String getHttpRequestMethod(HttpRequest request) {
2122
return request.method().value();
2223
}
@@ -39,11 +40,13 @@ public List<String> getHttpResponseHeader(
3940
}
4041

4142
@Override
43+
@Nullable
4244
public String getUrlScheme(HttpRequest request) {
4345
return request.uri().scheme();
4446
}
4547

4648
@Override
49+
@Nullable
4750
public String getUrlPath(HttpRequest request) {
4851
return request.uri().path().toString();
4952
}

‎instrumentation/apache-httpasyncclient-4.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpasyncclient/ApacheHttpAsyncClientHttpAttributesGetter.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ final class ApacheHttpAsyncClientHttpAttributesGetter
1818
implements HttpClientAttributesGetter<ApacheHttpClientRequest, HttpResponse> {
1919

2020
@Override
21+
@Nullable
2122
public String getHttpRequestMethod(ApacheHttpClientRequest request) {
2223
return request.getMethod();
2324
}
@@ -47,12 +48,14 @@ public List<String> getHttpResponseHeader(
4748
}
4849

4950
@Override
51+
@Nullable
5052
public String getNetworkProtocolName(
5153
ApacheHttpClientRequest request, @Nullable HttpResponse response) {
5254
return request.getProtocolName();
5355
}
5456

5557
@Override
58+
@Nullable
5659
public String getNetworkProtocolVersion(
5760
ApacheHttpClientRequest request, @Nullable HttpResponse response) {
5861
return request.getProtocolVersion();

‎instrumentation/apache-httpclient/apache-httpclient-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v2_0/ApacheHttpClientHttpAttributesGetter.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ final class ApacheHttpClientHttpAttributesGetter
2121
implements HttpClientAttributesGetter<HttpMethod, HttpMethod> {
2222

2323
@Override
24+
@Nullable
2425
public String getHttpRequestMethod(HttpMethod request) {
2526
return request.getName();
2627
}
@@ -77,6 +78,7 @@ public List<String> getHttpResponseHeader(HttpMethod request, HttpMethod respons
7778
}
7879

7980
@Override
81+
@Nullable
8082
public String getNetworkProtocolName(HttpMethod request, @Nullable HttpMethod response) {
8183
return "http";
8284
}

‎instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/ApacheHttpClientHttpAttributesGetter.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ final class ApacheHttpClientHttpAttributesGetter
1616
implements HttpClientAttributesGetter<ApacheHttpClientRequest, HttpResponse> {
1717

1818
@Override
19+
@Nullable
1920
public String getHttpRequestMethod(ApacheHttpClientRequest request) {
2021
return request.getMethod();
2122
}
@@ -43,12 +44,14 @@ public List<String> getHttpResponseHeader(
4344
}
4445

4546
@Override
47+
@Nullable
4648
public String getNetworkProtocolName(
4749
ApacheHttpClientRequest request, @Nullable HttpResponse response) {
4850
return request.getProtocolName();
4951
}
5052

5153
@Override
54+
@Nullable
5255
public String getNetworkProtocolVersion(
5356
ApacheHttpClientRequest request, @Nullable HttpResponse response) {
5457
return request.getProtocolVersion();

‎instrumentation/apache-httpclient/apache-httpclient-4.3/library/src/main/java/io/opentelemetry/instrumentation/apachehttpclient/v4_3/ApacheHttpClientHttpAttributesGetter.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ enum ApacheHttpClientHttpAttributesGetter
1818
INSTANCE;
1919

2020
@Override
21+
@Nullable
2122
public String getHttpRequestMethod(ApacheHttpClientRequest request) {
2223
return request.getMethod();
2324
}
@@ -46,12 +47,14 @@ public List<String> getHttpResponseHeader(
4647
}
4748

4849
@Override
50+
@Nullable
4951
public String getNetworkProtocolName(
5052
ApacheHttpClientRequest request, @Nullable HttpResponse response) {
5153
return request.getProtocolName();
5254
}
5355

5456
@Override
57+
@Nullable
5558
public String getNetworkProtocolVersion(
5659
ApacheHttpClientRequest request, @Nullable HttpResponse response) {
5760
return request.getProtocolVersion();

‎instrumentation/apache-httpclient/apache-httpclient-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v5_0/ApacheHttpClientHttpAttributesGetter.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ final class ApacheHttpClientHttpAttributesGetter
2121
implements HttpClientAttributesGetter<HttpRequest, HttpResponse> {
2222

2323
@Override
24+
@Nullable
2425
public String getHttpRequestMethod(HttpRequest request) {
2526
return request.getMethod();
2627
}

‎instrumentation/apache-httpclient/apache-httpclient-5.2/library/src/main/java/io/opentelemetry/instrumentation/apachehttpclient/v5_2/ApacheHttpClientHttpAttributesGetter.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ enum ApacheHttpClientHttpAttributesGetter
2020
INSTANCE;
2121

2222
@Override
23+
@Nullable
2324
public String getHttpRequestMethod(ApacheHttpClientRequest request) {
2425
return request.getMethod();
2526
}

‎instrumentation/armeria/armeria-1.3/library/src/main/java/io/opentelemetry/instrumentation/armeria/v1_3/internal/ArmeriaHttpClientAttributesGetter.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ protected Method computeValue(Class<?> type) {
3434
};
3535

3636
@Override
37+
@Nullable
3738
public String getHttpRequestMethod(ClientRequestContext ctx) {
3839
return ctx.method().name();
3940
}
@@ -83,11 +84,13 @@ public List<String> getHttpResponseHeader(
8384
}
8485

8586
@Override
87+
@Nullable
8688
public String getNetworkProtocolName(ClientRequestContext ctx, @Nullable RequestLog requestLog) {
8789
return "http";
8890
}
8991

9092
@Override
93+
@Nullable
9194
public String getNetworkProtocolVersion(
9295
ClientRequestContext ctx, @Nullable RequestLog requestLog) {
9396
SessionProtocol protocol =

0 commit comments

Comments
 (0)