Skip to content

Commit a2b44cc

Browse files
authored
Apply suggestions from code review
1 parent b207b25 commit a2b44cc

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/internal/OpenTelemetryConsumerInterceptor.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,6 @@ public void configure(Map<String, ?> configs) {
6363
consumerGroup = Objects.toString(configs.get(ConsumerConfig.GROUP_ID_CONFIG), null);
6464
clientId = Objects.toString(configs.get(ConsumerConfig.CLIENT_ID_CONFIG), null);
6565

66-
Object telemetrySupplier = configs.get(CONFIG_KEY_KAFKA_TELEMETRY_SUPPLIER);
67-
if (telemetrySupplier == null) {
68-
return;
69-
}
70-
7166
KafkaTelemetrySupplier supplier =
7267
getProperty(configs, CONFIG_KEY_KAFKA_TELEMETRY_SUPPLIER, KafkaTelemetrySupplier.class);
7368
this.telemetry = supplier.get();

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/internal/OpenTelemetryProducerInterceptor.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,6 @@ public void close() {}
4848
public void configure(Map<String, ?> configs) {
4949
clientId = Objects.toString(configs.get(ProducerConfig.CLIENT_ID_CONFIG), null);
5050

51-
Object telemetrySupplier = configs.get(CONFIG_KEY_KAFKA_TELEMETRY_SUPPLIER);
52-
if (telemetrySupplier == null) {
53-
return;
54-
}
55-
5651
KafkaTelemetrySupplier supplier =
5752
getProperty(configs, CONFIG_KEY_KAFKA_TELEMETRY_SUPPLIER, KafkaTelemetrySupplier.class);
5853
this.telemetry = supplier.get();

0 commit comments

Comments
 (0)