use stringArrayKey and asList from static import

Author: mznet

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingConsumerInterceptor.java

@@ -5,14 +5,15 @@
 
 package io.opentelemetry.instrumentation.kafkaclients.v2_6;
 
+import static java.util.Collections.emptyList;
+
 import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import io.opentelemetry.api.GlobalOpenTelemetry;
 import io.opentelemetry.context.Context;
 import io.opentelemetry.instrumentation.api.internal.ConfigPropertiesUtil;
 import io.opentelemetry.instrumentation.api.internal.Timer;
 import io.opentelemetry.instrumentation.kafkaclients.common.v0_11.internal.KafkaConsumerContext;
 import io.opentelemetry.instrumentation.kafkaclients.common.v0_11.internal.KafkaConsumerContextUtil;
-import java.util.ArrayList;
 import java.util.Map;
 import java.util.Objects;
 import org.apache.kafka.clients.consumer.ConsumerConfig;
@@ -35,7 +36,7 @@ public class TracingConsumerInterceptor<K, V> implements ConsumerInterceptor<K,
                   "otel.instrumentation.messaging.experimental.receive-telemetry.enabled", false))
           .setCapturedHeaders(
               ConfigPropertiesUtil.getList(
-                  "otel.instrumentation.messaging.experimental.capture-headers", new ArrayList<>()))
+                  "otel.instrumentation.messaging.experimental.capture-headers", emptyList()))
           .build();
 
   private String consumerGroup;

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/main/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/TracingProducerInterceptor.java

@@ -5,10 +5,11 @@
 
 package io.opentelemetry.instrumentation.kafkaclients.v2_6;
 
+import static java.util.Collections.emptyList;
+
 import com.google.errorprone.annotations.CanIgnoreReturnValue;
 import io.opentelemetry.api.GlobalOpenTelemetry;
 import io.opentelemetry.instrumentation.api.internal.ConfigPropertiesUtil;
-import java.util.ArrayList;
 import java.util.Map;
 import java.util.Objects;
 import javax.annotation.Nullable;
@@ -28,7 +29,7 @@ public class TracingProducerInterceptor<K, V> implements ProducerInterceptor<K,
       KafkaTelemetry.builder(GlobalOpenTelemetry.get())
           .setCapturedHeaders(
               ConfigPropertiesUtil.getList(
-                  "otel.instrumentation.messaging.experimental.capture-headers", new ArrayList<>()))
+                  "otel.instrumentation.messaging.experimental.capture-headers", emptyList()))
           .build();
 
   @Nullable private String clientId;

instrumentation/kafka/kafka-clients/kafka-clients-2.6/library/src/test/java/io/opentelemetry/instrumentation/kafkaclients/v2_6/InterceptorsTest.java

@@ -5,6 +5,7 @@
 
 package io.opentelemetry.instrumentation.kafkaclients.v2_6;
 
+import static io.opentelemetry.api.common.AttributeKey.stringArrayKey;
 import static io.opentelemetry.instrumentation.testing.util.TelemetryDataUtil.orderByRootSpanName;
 import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
 import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.satisfies;
@@ -16,6 +17,7 @@
 import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_MESSAGE_BODY_SIZE;
 import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_OPERATION;
 import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_SYSTEM;
+import static java.util.Arrays.asList;
 import static org.assertj.core.api.Assertions.assertThat;
 
 import io.opentelemetry.api.common.AttributeKey;
@@ -45,8 +47,8 @@ void assertTraces() {
                       .hasParent(trace.getSpan(0))
                       .hasAttributesSatisfyingExactly(
                           equalTo(
-                              AttributeKey.stringArrayKey("messaging.header.baggage"),
-                              Arrays.asList(
+                              stringArrayKey("messaging.header.baggage"),
+                              asList(
                                   "test-baggage-key-1=test-baggage-value-1",
                                   "test-baggage-key-2=test-baggage-value-2")),
                           equalTo(MESSAGING_SYSTEM, "kafka"),

instrumentation/kafka/kafka-clients/kafka-clients-2.6/metadata.yaml

@@ -6,6 +6,8 @@ configurations:
     type: list
     default: ''
   - name: otel.instrumentation.messaging.experimental.receive-telemetry.enabled
-    description: Enables experimental receive telemetry for Kafka instrumentation.
+    description: >
+      Enables experimental receive telemetry, which will cause consumers to start a new trace, with
+      only a span link connecting it to the producer trace.
     type: boolean
     default: false