Skip to content

Commit a4b635e

Browse files
committed
Fix flaky couchbase spring test
1 parent be153f0 commit a4b635e

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

instrumentation/couchbase/couchbase-common/testing/src/main/java/io/opentelemetry/instrumentation/couchbase/springdata/AbstractCouchbaseSpringRepositoryTest.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
import com.couchbase.client.java.view.DesignDocument;
1515
import io.opentelemetry.api.trace.SpanKind;
1616
import io.opentelemetry.instrumentation.couchbase.AbstractCouchbaseTest;
17+
import io.opentelemetry.instrumentation.testing.internal.AutoCleanupExtension;
1718
import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension;
1819
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
1920
import java.util.Collections;
2021
import org.junit.jupiter.api.AfterAll;
21-
import org.junit.jupiter.api.AfterEach;
2222
import org.junit.jupiter.api.BeforeAll;
2323
import org.junit.jupiter.api.Test;
2424
import org.junit.jupiter.api.extension.RegisterExtension;
@@ -30,6 +30,8 @@ public abstract class AbstractCouchbaseSpringRepositoryTest extends AbstractCouc
3030
@RegisterExtension
3131
static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
3232

33+
@RegisterExtension static final AutoCleanupExtension cleanup = AutoCleanupExtension.create();
34+
3335
private ConfigurableApplicationContext applicationContext;
3436
private TestRepository repository;
3537

@@ -64,11 +66,10 @@ void setUp() {
6466
repository = applicationContext.getBean(TestRepository.class);
6567
}
6668

67-
@AfterEach
68-
void cleanUpTest() {
69+
private void cleanUpTest() {
6970
testing.clearData();
7071
repository.deleteAll();
71-
testing.waitForTraces(1);
72+
testing.waitForTraces(2);
7273
}
7374

7475
@AfterAll
@@ -103,6 +104,7 @@ void emptyRepo() {
103104
void save() {
104105
TestDocument document = new TestDocument();
105106
TestDocument result = repository.save(document);
107+
cleanup.deferCleanup(this::cleanUpTest);
106108

107109
assertThat(result).isEqualTo(document);
108110

@@ -124,6 +126,7 @@ void saveAndRetrieve() {
124126
repository.save(document);
125127
return findById(repository, "1");
126128
});
129+
cleanup.deferCleanup(this::cleanUpTest);
127130

128131
assertThat(result).isEqualTo(document);
129132

@@ -149,6 +152,7 @@ void saveAndUpdate() {
149152
document.setData("other data");
150153
repository.save(document);
151154
});
155+
cleanup.deferCleanup(this::cleanUpTest);
152156

153157
testing.waitAndAssertTraces(
154158
trace ->

0 commit comments

Comments
 (0)