Migrating RouteConcatenationInstrumentation

LikeTheSalad · LikeTheSalad · commit aa63bb7dffa8 · 2025-10-24T13:47:43.000+02:00
diff --git a/instrumentation/pekko/pekko-http-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/pekkohttp/v1_0/server/route/RouteConcatenationInstrumentation.java b/instrumentation/pekko/pekko-http-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/pekkohttp/v1_0/server/route/RouteConcatenationInstrumentation.java
@@ -33,11 +33,11 @@ public void transform(TypeTransformer transformer) {
   @SuppressWarnings("unused")
   public static class ApplyAdvice {
 
+    @Advice.AssignReturned.ToArguments(@Advice.AssignReturned.ToArguments.ToArgument(0))
     @Advice.OnMethodEnter(suppress = Throwable.class)
-    public static void onEnter(
-        @Advice.Argument(value = 0, readOnly = false)
-            Function1<RequestContext, Future<RouteResult>> route) {
-      route = new PekkoRouteWrapper(route);
+    public static Object onEnter(
+        @Advice.Argument(0) Function1<RequestContext, Future<RouteResult>> route) {
+      return new PekkoRouteWrapper(route);
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -33,11 +33,11 @@ public void transform(TypeTransformer transformer) {`
`33`	`33`	`@SuppressWarnings("unused")`
`34`	`34`	`public static class ApplyAdvice {`
`35`	`35`
	`36`	`+ @Advice.AssignReturned.ToArguments(@Advice.AssignReturned.ToArguments.ToArgument(0))`
`36`	`37`	`@Advice.OnMethodEnter(suppress = Throwable.class)`
`37`		`- public static void onEnter(`
`38`		`- @Advice.Argument(value = 0, readOnly = false)`
`39`		`- Function1<RequestContext, Future<RouteResult>> route) {`
`40`		`- route = new PekkoRouteWrapper(route);`
	`38`	`+ public static Object onEnter(`
	`39`	`+ @Advice.Argument(0) Function1<RequestContext, Future<RouteResult>> route) {`
	`40`	`+ return new PekkoRouteWrapper(route);`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`	`}`