pr review

Author: zeitlinger

instrumentation/servlet/servlet-common/bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/servlet/ExperimentalSnippetHolder.java

@@ -6,6 +6,7 @@
 package io.opentelemetry.javaagent.bootstrap.servlet;
 
 import io.opentelemetry.api.GlobalOpenTelemetry;
+import io.opentelemetry.api.OpenTelemetry;
 import io.opentelemetry.instrumentation.api.incubator.config.internal.DeclarativeConfigUtil;
 import io.opentelemetry.instrumentation.api.internal.ConfigPropertiesUtil;
 
@@ -14,9 +15,12 @@ public class ExperimentalSnippetHolder {
   private static volatile String snippet = getSnippetSetting();
 
   private static String getSnippetSetting() {
-    return DeclarativeConfigUtil.getInstrumentationConfig(GlobalOpenTelemetry.get(), "servlet")
+    OpenTelemetry openTelemetry = GlobalOpenTelemetry.get();
+    return DeclarativeConfigUtil.getInstrumentationConfig(openTelemetry, "servlet")
         .getString(
             "javascript_snippet/development",
+            // use ConfigPropertiesUtil only to prevent that the deprecated property is used in
+            // declarative config
             ConfigPropertiesUtil.getString("otel.experimental.javascript-snippet", ""));
   }