Skip to content

Commit acbab58

Browse files
Update the OpenTelemetry SDK version to 1.28.0 (#8897)
Co-authored-by: Lauri Tulmin <[email protected]>
1 parent 6f09cf7 commit acbab58

File tree

12 files changed

+89
-65
lines changed

12 files changed

+89
-65
lines changed

dependencyManagement/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ val dependencyVersions = hashMapOf<String, String>()
1212
rootProject.extra["versions"] = dependencyVersions
1313

1414
// this line is managed by .github/scripts/update-sdk-version.sh
15-
val otelSdkVersion = "1.27.0"
15+
val otelSdkVersion = "1.28.0"
1616
val otelSdkAlphaVersion = otelSdkVersion.replaceFirst("(-SNAPSHOT)?$".toRegex(), "-alpha$1")
1717

1818
// Need both BOM and groovy jars

instrumentation/jmx-metrics/javaagent/src/main/java/io/opentelemetry/instrumentation/javaagent/jmx/JmxMetricInsightInstaller.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import io.opentelemetry.instrumentation.jmx.yaml.RuleParser;
1616
import io.opentelemetry.javaagent.extension.AgentListener;
1717
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
18+
import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
1819
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1920
import java.io.InputStream;
2021
import java.nio.file.Files;
@@ -27,7 +28,7 @@ public class JmxMetricInsightInstaller implements AgentListener {
2728

2829
@Override
2930
public void afterAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredSdk) {
30-
ConfigProperties config = autoConfiguredSdk.getConfig();
31+
ConfigProperties config = AutoConfigureUtil.getConfig(autoConfiguredSdk);
3132

3233
if (config.getBoolean("otel.jmx.enabled", true)) {
3334
JmxMetricInsight service =

instrumentation/oshi/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/oshi/OshiMetricsInstaller.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import com.google.auto.service.AutoService;
99
import io.opentelemetry.javaagent.extension.AgentListener;
1010
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
11+
import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
1112
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1213
import java.lang.reflect.Method;
1314

@@ -20,7 +21,7 @@ public class OshiMetricsInstaller implements AgentListener {
2021

2122
@Override
2223
public void afterAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredSdk) {
23-
ConfigProperties config = autoConfiguredSdk.getConfig();
24+
ConfigProperties config = AutoConfigureUtil.getConfig(autoConfiguredSdk);
2425

2526
boolean defaultEnabled = config.getBoolean("otel.instrumentation.common.default-enabled", true);
2627
if (!config.getBoolean("otel.instrumentation.oshi.enabled", defaultEnabled)) {

instrumentation/runtime-telemetry/runtime-telemetry-java17/javaagent/src/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java17/Java17RuntimeMetricsInstaller.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import io.opentelemetry.instrumentation.runtimemetrics.java17.RuntimeMetrics;
1212
import io.opentelemetry.javaagent.extension.AgentListener;
1313
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
14+
import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
1415
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1516

1617
/** An {@link AgentListener} that enables runtime metrics during agent startup. */
@@ -19,7 +20,7 @@ public class Java17RuntimeMetricsInstaller implements AgentListener {
1920

2021
@Override
2122
public void afterAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredSdk) {
22-
ConfigProperties config = autoConfiguredSdk.getConfig();
23+
ConfigProperties config = AutoConfigureUtil.getConfig(autoConfiguredSdk);
2324

2425
OpenTelemetry openTelemetry = GlobalOpenTelemetry.get();
2526
RuntimeMetrics runtimeMetrics = null;

instrumentation/runtime-telemetry/runtime-telemetry-java8/javaagent/src/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/Java8RuntimeMetricsInstaller.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import io.opentelemetry.instrumentation.runtimemetrics.java8.internal.JmxRuntimeMetricsUtil;
1818
import io.opentelemetry.javaagent.extension.AgentListener;
1919
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
20+
import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
2021
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
2122
import java.util.ArrayList;
2223
import java.util.List;
@@ -27,7 +28,7 @@ public class Java8RuntimeMetricsInstaller implements AgentListener {
2728

2829
@Override
2930
public void afterAgent(AutoConfiguredOpenTelemetrySdk autoConfiguredSdk) {
30-
ConfigProperties config = autoConfiguredSdk.getConfig();
31+
ConfigProperties config = AutoConfigureUtil.getConfig(autoConfiguredSdk);
3132

3233
boolean defaultEnabled = config.getBoolean("otel.instrumentation.common.default-enabled", true);
3334
if (!config.getBoolean("otel.instrumentation.runtime-telemetry.enabled", defaultEnabled)

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/exporters/jaeger/JaegerSpanExporterAutoConfiguration.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55

66
package io.opentelemetry.instrumentation.spring.autoconfigure.exporters.jaeger;
77

8-
import io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter;
9-
import io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporterBuilder;
108
import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration;
119
import org.springframework.boot.autoconfigure.AutoConfigureBefore;
1210
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
@@ -17,22 +15,26 @@
1715
import org.springframework.context.annotation.Configuration;
1816

1917
/**
20-
* Configures {@link JaegerGrpcSpanExporter} for tracing.
18+
* Configures {@link io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter} for tracing.
2119
*
22-
* <p>Initializes {@link JaegerGrpcSpanExporter} bean if bean is missing.
20+
* <p>Initializes {@link io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter} bean if bean is
21+
* missing.
2322
*/
2423
@Configuration
2524
@AutoConfigureBefore(OpenTelemetryAutoConfiguration.class)
2625
@EnableConfigurationProperties(JaegerSpanExporterProperties.class)
2726
@ConditionalOnProperty(prefix = "otel.exporter.jaeger", name = "enabled", matchIfMissing = true)
28-
@ConditionalOnClass(JaegerGrpcSpanExporter.class)
27+
@ConditionalOnClass(io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter.class)
28+
@Deprecated
2929
public class JaegerSpanExporterAutoConfiguration {
3030

3131
@Bean
3232
@ConditionalOnMissingBean
33-
public JaegerGrpcSpanExporter otelJaegerSpanExporter(JaegerSpanExporterProperties properties) {
33+
public io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter otelJaegerSpanExporter(
34+
JaegerSpanExporterProperties properties) {
3435

35-
JaegerGrpcSpanExporterBuilder builder = JaegerGrpcSpanExporter.builder();
36+
io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporterBuilder builder =
37+
io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter.builder();
3638
if (properties.getEndpoint() != null) {
3739
builder.setEndpoint(properties.getEndpoint());
3840
}

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/exporters/jaeger/JaegerSpanExporterProperties.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
* <p>Get max wait time for Collector to process Span Batches
2020
*/
2121
@ConfigurationProperties(prefix = "otel.exporter.jaeger")
22+
@Deprecated
2223
public final class JaegerSpanExporterProperties {
2324

2425
private boolean enabled = true;

instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/exporters/jaeger/JaegerSpanExporterAutoConfigurationTest.java

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,18 @@
88
import static org.assertj.core.api.Assertions.assertThat;
99

1010
import io.opentelemetry.api.GlobalOpenTelemetry;
11-
import io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter;
1211
import io.opentelemetry.instrumentation.spring.autoconfigure.OpenTelemetryAutoConfiguration;
1312
import org.junit.jupiter.api.BeforeEach;
1413
import org.junit.jupiter.api.DisplayName;
1514
import org.junit.jupiter.api.Test;
1615
import org.springframework.boot.autoconfigure.AutoConfigurations;
1716
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
1817

19-
/** Spring Boot auto configuration test for {@link JaegerGrpcSpanExporter}. */
18+
/**
19+
* Spring Boot auto configuration test for {@link
20+
* io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter}.
21+
*/
22+
@SuppressWarnings("deprecation")
2023
class JaegerSpanExporterAutoConfigurationTest {
2124

2225
private final ApplicationContextRunner contextRunner =
@@ -37,7 +40,10 @@ void exportersEnabled() {
3740
.withPropertyValues("otel.exporter.jaeger.enabled=true")
3841
.run(
3942
context ->
40-
assertThat(context.getBean("otelJaegerSpanExporter", JaegerGrpcSpanExporter.class))
43+
assertThat(
44+
context.getBean(
45+
"otelJaegerSpanExporter",
46+
io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter.class))
4147
.isNotNull());
4248
}
4349

@@ -74,7 +80,10 @@ void disabledProperty() {
7480
void noProperty() {
7581
this.contextRunner.run(
7682
context ->
77-
assertThat(context.getBean("otelJaegerSpanExporter", JaegerGrpcSpanExporter.class))
83+
assertThat(
84+
context.getBean(
85+
"otelJaegerSpanExporter",
86+
io.opentelemetry.exporter.jaeger.JaegerGrpcSpanExporter.class))
7887
.isNotNull());
7988
}
8089
}

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentInstaller.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import io.opentelemetry.javaagent.tooling.muzzle.AgentTooling;
4242
import io.opentelemetry.javaagent.tooling.util.Trie;
4343
import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
44+
import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
4445
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
4546
import java.lang.instrument.Instrumentation;
4647
import java.util.ArrayList;
@@ -119,7 +120,7 @@ private static void installBytebuddyAgent(
119120
AutoConfiguredOpenTelemetrySdk autoConfiguredSdk =
120121
installOpenTelemetrySdk(extensionClassLoader);
121122

122-
ConfigProperties sdkConfig = autoConfiguredSdk.getConfig();
123+
ConfigProperties sdkConfig = AutoConfigureUtil.getConfig(autoConfiguredSdk);
123124
InstrumentationConfig.internalInitializeConfig(new ConfigPropertiesBridge(sdkConfig));
124125
copyNecessaryConfigToSystemProperties(sdkConfig);
125126

@@ -286,7 +287,8 @@ private static void runAfterAgentListeners(
286287
// the application is already setting the global LogManager and AgentListener won't be able
287288
// to touch it due to class loader locking.
288289
boolean shouldForceSynchronousAgentListenersCalls =
289-
autoConfiguredSdk.getConfig().getBoolean(FORCE_SYNCHRONOUS_AGENT_LISTENERS_CONFIG, false);
290+
AutoConfigureUtil.getConfig(autoConfiguredSdk)
291+
.getBoolean(FORCE_SYNCHRONOUS_AGENT_LISTENERS_CONFIG, false);
290292
boolean javaBefore9 = isJavaBefore9();
291293
if (!shouldForceSynchronousAgentListenersCalls && javaBefore9 && isAppUsingCustomLogManager()) {
292294
logger.fine("Custom JUL LogManager detected: delaying AgentListener#afterAgent() calls");

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/OpenTelemetryInstaller.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public static AutoConfiguredOpenTelemetrySdk installOpenTelemetrySdk(
2626

2727
AutoConfiguredOpenTelemetrySdk autoConfiguredSdk =
2828
AutoConfiguredOpenTelemetrySdk.builder()
29-
.setResultAsGlobal(true)
29+
.setResultAsGlobal()
3030
.setServiceClassLoader(extensionClassLoader)
3131
// disable the logs exporter by default for the time being
3232
// FIXME remove this in the 2.x branch

0 commit comments

Comments
 (0)