fix some build issues

Author: ghareeb-falazi

instrumentation/iceberg-1.8/library/build.gradle.kts

@@ -3,5 +3,5 @@ plugins {
 }
 
 dependencies {
-  implementation("org.apache.iceberg:iceberg-core:1.8.1")
+  library("org.apache.iceberg:iceberg-core:1.8.1")
 }

instrumentation/iceberg-1.8/library/src/main/java/opentlelemetry/instrumentation/iceberg/v1_6/IcebergMetricsReporter.java renamed to instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergMetricsReporter.java

@@ -3,7 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-package opentlelemetry.instrumentation.iceberg.v1_6;
+package io.opentelemetry.instrumentation.iceberg.v1_8;
 
 import org.apache.iceberg.metrics.CommitReport;
 import org.apache.iceberg.metrics.CounterResult;
@@ -64,15 +64,17 @@ void reportScanMetrics(ScanReport scanReport) {
 
     if (current != null) {
       DoubleGauge metric =
-          ScanMetricsBuilder.scannedDataManifestsCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
+          ScanMetricsBuilder.scannedDataManifestsCount(
+              openTelemetry.getMeter(INSTRUMENTATION_NAME));
       metric.set(current.value());
     }
 
     current = metrics.scannedDeleteManifests();
 
     if (current != null) {
       DoubleGauge metric =
-          ScanMetricsBuilder.scannedDeleteManifestsCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
+          ScanMetricsBuilder.scannedDeleteManifestsCount(
+              openTelemetry.getMeter(INSTRUMENTATION_NAME));
       metric.set(current.value());
     }
 
@@ -88,7 +90,8 @@ void reportScanMetrics(ScanReport scanReport) {
 
     if (current != null) {
       DoubleGauge metric =
-          ScanMetricsBuilder.totalDeleteManifestsCount(openTelemetry.getMeter(INSTRUMENTATION_NAME));
+          ScanMetricsBuilder.totalDeleteManifestsCount(
+              openTelemetry.getMeter(INSTRUMENTATION_NAME));
       metric.set(current.value());
     }
 
@@ -171,7 +174,6 @@ void reportScanMetrics(ScanReport scanReport) {
           ScanMetricsBuilder.deletionVectorFiles(openTelemetry.getMeter(INSTRUMENTATION_NAME));
       metric.set(current.value());
     }
-
   }
 
   void reportCommitMetrics(CommitReport commitReport) {}

instrumentation/iceberg-1.8/library/src/main/java/opentlelemetry/instrumentation/iceberg/v1_6/IcebergTelemetry.java renamed to instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergTelemetry.java

@@ -3,11 +3,12 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-package opentlelemetry.instrumentation.iceberg.v1_6;
+package io.opentelemetry.instrumentation.iceberg.v1_8;
 
-import io.opentelemetry.api.OpenTelemetry;
 import org.apache.iceberg.TableScan;
 
+import io.opentelemetry.api.OpenTelemetry;
+
 public class IcebergTelemetry {
   private final OpenTelemetry openTelemetry;
 

instrumentation/iceberg-1.8/library/src/main/java/opentlelemetry/instrumentation/iceberg/v1_6/ScanMetricsBuilder.java renamed to instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/ScanMetricsBuilder.java

@@ -3,12 +3,12 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-package opentlelemetry.instrumentation.iceberg.v1_6;
+package io.opentelemetry.instrumentation.iceberg.v1_8;
 
 import io.opentelemetry.api.metrics.DoubleGauge;
 import io.opentelemetry.api.metrics.Meter;
 
-public class ScanMetricsBuilder {
+final class ScanMetricsBuilder {
   private static final String ROOT = "iceberg.scan";
   private static final String TOTAL_PLANNING_DURATION = ROOT + ".planning.duration";
   private static final String RESULT_DATA_FILES = ROOT + ".scanned.data_files.count";
@@ -29,6 +29,10 @@ public class ScanMetricsBuilder {
       ROOT + ".scanned.positional_delete_files.count";
   private static final String DVS = ROOT + ".scanned.dvs.count";
 
+  private ScanMetricsBuilder() {
+    // prevents instantiation
+  }
+
   static DoubleGauge totalPlanningDuration(Meter meter) {
     return meter
         .gaugeBuilder(TOTAL_PLANNING_DURATION)