Skip to content

Commit aeae7e8

Browse files
committed
fix jaxrs
1 parent 8411054 commit aeae7e8

File tree

3 files changed

+17
-19
lines changed

3 files changed

+17
-19
lines changed

instrumentation/jaxrs/jaxrs-common/testing/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsFilterTest.java

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@
55

66
package io.opentelemetry.instrumentation.jaxrs;
77

8-
import static io.opentelemetry.instrumentation.testing.junit.code.SemconvCodeStabilityUtil.codeFunctionAssertions;
9-
import static io.opentelemetry.instrumentation.testing.junit.code.SemconvCodeStabilityUtil.codeFunctionPrefixAssertions;
8+
import static io.opentelemetry.instrumentation.testing.junit.code.SemconvCodeStabilityUtil.codeFunctionInfixAssertions;
109
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
1110
import static io.opentelemetry.semconv.ErrorAttributes.ERROR_TYPE;
1211
import static io.opentelemetry.semconv.HttpAttributes.HTTP_REQUEST_METHOD;
@@ -143,13 +142,10 @@ void request(
143142
List<AttributeAssertion> assertions;
144143
if (abortPrematch) {
145144
assertions =
146-
codeFunctionAssertions(
147-
"JaxRsFilterTest$PrematchRequestFilter", "filter");
145+
codeFunctionInfixAssertions(
146+
".JaxRsFilterTest$PrematchRequestFilter", "filter");
148147
} else {
149-
assertions =
150-
codeFunctionPrefixAssertions(
151-
"io.opentelemetry.instrumentation.jaxrs.v2_0.test.Resource$Test",
152-
"hello");
148+
assertions = codeFunctionInfixAssertions(".Resource$Test", "hello");
153149
}
154150
span.hasAttributesSatisfyingExactly(assertions);
155151
}));
@@ -185,8 +181,6 @@ void nestedCall() throws Exception {
185181
.hasKind(SpanKind.INTERNAL)
186182
.hasParent(trace.getSpan(0))
187183
.hasAttributesSatisfyingExactly(
188-
codeFunctionPrefixAssertions(
189-
"io.opentelemetry.instrumentation.jaxrs.v2_0.test.Resource$Test",
190-
"nested"))));
184+
codeFunctionInfixAssertions(".Resource$Test", "nested"))));
191185
}
192186
}

instrumentation/jaxrs/jaxrs-common/testing/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsHttpServerTest.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
package io.opentelemetry.instrumentation.jaxrs;
77

8-
import static io.opentelemetry.instrumentation.testing.junit.code.SemconvCodeStabilityUtil.codeFunctionAssertions;
8+
import static io.opentelemetry.instrumentation.testing.junit.code.SemconvCodeStabilityUtil.codeFunctionInfixAssertions;
99
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
1010
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
1111
import static java.util.concurrent.TimeUnit.SECONDS;
@@ -190,8 +190,7 @@ void shouldHandleAsyncResponse(AsyncResponseTestKind testKind) throws Exception
190190
testKind.assertBody(response.contentUtf8());
191191

192192
List<AttributeAssertion> attributeAssertions =
193-
codeFunctionAssertions(
194-
"io.opentelemetry.instrumentation.jaxrs.v2_0.test.JaxRsTestResource", "asyncOp");
193+
codeFunctionInfixAssertions("test.JaxRsTestResource", "asyncOp");
195194

196195
if (testKind == AsyncResponseTestKind.CANCELED) {
197196
attributeAssertions.add(equalTo(AttributeKey.booleanKey("jaxrs.canceled"), true));
@@ -301,9 +300,7 @@ void shouldHandleCompletionStage(CompletionStageTestKind testKind) throws Except
301300
.hasKind(SpanKind.INTERNAL)
302301
.hasParent(trace.getSpan(0))
303302
.hasAttributesSatisfyingExactly(
304-
codeFunctionAssertions(
305-
"io.opentelemetry.instrumentation.jaxrs.v2_0.test.JaxRsTestResource",
306-
"jaxRs21Async"));
303+
codeFunctionInfixAssertions(".JaxRsTestResource", "jaxRs21Async"));
307304
if (testKind == CompletionStageTestKind.FAILING) {
308305
span.hasStatus(StatusData.error())
309306
.hasException(new IllegalStateException("failure"));
@@ -318,7 +315,6 @@ protected SpanDataAssert assertHandlerSpan(
318315
return span.hasName("JaxRsTestResource." + methodName)
319316
.hasKind(SpanKind.INTERNAL)
320317
.hasAttributesSatisfyingExactly(
321-
codeFunctionAssertions(
322-
"io.opentelemetry.instrumentation.jaxrs.v2_0.test.JaxRsTestResource", methodName));
318+
codeFunctionInfixAssertions(".JaxRsTestResource", methodName));
323319
}
324320
}

testing-common/src/main/java/io/opentelemetry/instrumentation/testing/junit/code/SemconvCodeStabilityUtil.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,14 @@ public static List<AttributeAssertion> codeFunctionSuffixAssertions(
5959
v -> v.endsWith(namespaceSuffix));
6060
}
6161

62+
public static List<AttributeAssertion> codeFunctionInfixAssertions(
63+
String namespaceInfix, String methodName) {
64+
return internalFunctionAssert(
65+
methodName,
66+
v -> v.contains(namespaceInfix).endsWith("." + methodName),
67+
v -> v.contains(namespaceInfix));
68+
}
69+
6270
public static List<AttributeAssertion> codeFunctionPrefixAssertions(
6371
String namespacePrefix, String methodName) {
6472
return internalFunctionAssert(

0 commit comments

Comments
 (0)