apply suggestions from code review

Author: ghareeb-falazi

instrumentation/iceberg-1.8/library/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/ScanMetricsBuilder.java

@@ -95,15 +95,15 @@ static LongCounter scannedDataFilesSize(Meter meter) {
     return meter
         .counterBuilder(TOTAL_FILE_SIZE_IN_BYTES)
         .setDescription("The total size of all scanned data files.")
-        .setUnit("byte")
+        .setUnit("By")
         .build();
   }
 
   static LongCounter scannedDeleteFilesSize(Meter meter) {
     return meter
         .counterBuilder(TOTAL_DELETE_FILE_SIZE_IN_BYTES)
         .setDescription("The total size of all scanned delete files.")
-        .setUnit("byte")
+        .setUnit("By")
         .build();
   }
 

instrumentation/iceberg-1.8/library/src/test/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergLibraryTest.java renamed to instrumentation/iceberg-1.8/library/src/test/java/io/opentelemetry/instrumentation/iceberg/v1_8/IcebergTest.java

@@ -5,13 +5,14 @@
 
 package io.opentelemetry.instrumentation.iceberg.v1_8;
 
+import org.apache.iceberg.TableScan;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
 import io.opentelemetry.api.OpenTelemetry;
 import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
 import io.opentelemetry.instrumentation.testing.junit.LibraryInstrumentationExtension;
-import org.apache.iceberg.TableScan;
-import org.junit.jupiter.api.extension.RegisterExtension;
 
-public class IcebergLibraryTest extends AbstractIcebergTest {
+class IcebergTest extends AbstractIcebergTest {
   @RegisterExtension
   final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
 

instrumentation/iceberg-1.8/testing/src/main/java/io/opentelemetry/instrumentation/iceberg/v1_8/AbstractIcebergTest.java

@@ -9,12 +9,11 @@
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
-import io.opentelemetry.api.common.Attributes;
-import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
 import java.io.File;
 import java.io.IOException;
 import java.util.Arrays;
 import java.util.Locale;
+
 import org.apache.iceberg.DataFile;
 import org.apache.iceberg.DataFiles;
 import org.apache.iceberg.FileScanTask;
@@ -38,6 +37,9 @@
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
+import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
+
 public abstract class AbstractIcebergTest {
   protected static final int FORMAT_VERSION = 2;
   protected static final Schema SCHEMA =
@@ -172,7 +174,7 @@ void testCreateTelemetry() throws IOException {
 
     if (currentExpectedMetric != null) {
       assertIcebergCounterMetric(
-          "iceberg.scan.scanned.data_files.size", "byte", expected, currentExpectedMetric.value());
+          "iceberg.scan.scanned.data_files.size", "By", expected, currentExpectedMetric.value());
     } else {
       assertIcebergMetricNotReported("iceberg.scan.scanned.data_files.size");
     }
@@ -182,7 +184,7 @@ void testCreateTelemetry() throws IOException {
     if (currentExpectedMetric != null) {
       assertIcebergCounterMetric(
           "iceberg.scan.scanned.delete_files.size",
-          "byte",
+          "By",
           expected,
           currentExpectedMetric.value());
     } else {
@@ -310,7 +312,7 @@ private void assertIcebergGaugeMetric(
       String otelMetricName, String expectedUnit, ScanReport expectedReport, long expectedValue) {
     testing()
         .waitAndAssertMetrics(
-            "io.opentelemetry.iceberg_1.8",
+            "io.opentelemetry.iceberg-1.8",
             metricAssert ->
                 metricAssert
                     .hasName(otelMetricName)
@@ -342,7 +344,7 @@ private void assertIcebergCounterMetric(
       String otelMetricName, String expectedUnit, ScanReport expectedReport, long expectedValue) {
     testing()
         .waitAndAssertMetrics(
-            "io.opentelemetry.iceberg_1.8",
+            "io.opentelemetry.iceberg-1.8",
             metricAssert ->
                 metricAssert
                     .hasName(otelMetricName)