thou shall lint

Author: SylvainJuge

instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/yaml/JmxRule.java

@@ -170,7 +170,7 @@ public MetricDef buildMetricDef() throws Exception {
           combineMetricAttributes(ownAttributes, metricAttributes);
 
       // higher priority to metric level mapping, then jmx rule as fallback
-      final StateMapping stateMapping = getEffectiveStateMapping(m, this);
+      StateMapping stateMapping = getEffectiveStateMapping(m, this);
 
       if (stateMapping.isEmpty()) {
         MetricExtractor metricExtractor =

instrumentation/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/yaml/StateMapping.java

@@ -36,6 +36,8 @@ private StateMapping(
   }
 
   /**
+   * Returns {@literal} true when empty, {@literal false} otherwise
+   *
    * @return {@literal true} when state mapping is empty, {@literal false} otherwise
    */
   public boolean isEmpty() {

instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/engine/RuleParserTest.java

@@ -10,7 +10,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.entry;
-import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.when;
 
 import io.opentelemetry.instrumentation.jmx.yaml.JmxConfig;
 import io.opentelemetry.instrumentation.jmx.yaml.JmxRule;
@@ -400,7 +400,7 @@ void testStateMetricConf() throws Exception {
 
     ObjectName objectName = new ObjectName(jmxRule.getBean());
     MBeanServerConnection mockConnection = Mockito.mock(MBeanServerConnection.class);
-    doReturn("STOPPED").when(mockConnection).getAttribute(objectName, "jmxStateAttribute");
+    when(mockConnection.getAttribute(objectName, "jmxStateAttribute")).thenReturn("STOPPED");
 
     MetricDef metricDef = jmxRule.buildMetricDef();
     assertThat(metricDef.getMetricExtractors())