pr review

Author: zeitlinger

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/cache/weaklockfree/AbstractWeakConcurrentMap.java

@@ -333,11 +333,11 @@ public int hashCode() {
     }
 
     @Override
-    public boolean equals(@Nullable Object other) {
+    public boolean equals(Object other) {
       if (other instanceof WeakKey<?>) {
         return ((WeakKey<?>) other).get() == get();
       } else {
-        return requireNonNull(other).equals(this);
+        return other.equals(this);
       }
     }
 
@@ -379,11 +379,12 @@ public boolean hasNext() {
 
     @Override
     public Map.Entry<K, V> next() {
-      if (nextKey == null) {
+      K key = nextKey;
+      if (key == null) {
         throw new NoSuchElementException();
       }
       try {
-        return new SimpleEntry(requireNonNull(nextKey), requireNonNull(nextEntry));
+        return new SimpleEntry(key, requireNonNull(nextEntry));
       } finally {
         findNext();
       }

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/cache/weaklockfree/WeakConcurrentMap.java

@@ -25,8 +25,6 @@
 
 package io.opentelemetry.instrumentation.api.internal.cache.weaklockfree;
 
-import static java.util.Objects.requireNonNull;
-
 import java.util.Iterator;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
@@ -161,11 +159,11 @@ void reset() {
     }
 
     @Override
-    public boolean equals(@Nullable Object other) {
+    public boolean equals(Object other) {
       if (other instanceof WeakConcurrentMap.LookupKey<?>) {
         return ((LookupKey<?>) other).key == key;
       } else {
-        return ((AbstractWeakConcurrentMap.WeakKey<?>) requireNonNull(other)).get() == key;
+        return ((AbstractWeakConcurrentMap.WeakKey<?>) other).get() == key;
       }
     }