Skip to content

Commit b10c09c

Browse files
authored
Simplify zio instrumentation (#14808)
1 parent 903e55c commit b10c09c

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

instrumentation/zio/zio-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/zio/v2_0/TracingSupervisor.java

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,11 @@
1818
@SuppressWarnings("unchecked")
1919
public final class TracingSupervisor extends Supervisor<Object> {
2020

21-
@SuppressWarnings("rawtypes")
22-
public static final VirtualField<Fiber.Runtime, FiberContext> RUNTIME_FIBER_CONTEXT =
21+
public static final TracingSupervisor INSTANCE = new TracingSupervisor();
22+
private static final VirtualField<Fiber.Runtime<?, ?>, FiberContext> RUNTIME_FIBER_CONTEXT =
2323
VirtualField.find(Fiber.Runtime.class, FiberContext.class);
2424

25-
@SuppressWarnings("rawtypes")
26-
private final VirtualField<Fiber.Runtime, FiberContext> virtualField;
27-
28-
@SuppressWarnings("rawtypes")
29-
public TracingSupervisor(VirtualField<Fiber.Runtime, FiberContext> virtualField) {
30-
this.virtualField = virtualField;
31-
}
25+
private TracingSupervisor() {}
3226

3327
@Override
3428
@SuppressWarnings("rawtypes")
@@ -44,23 +38,23 @@ public <R, E, A1> void onStart(
4438
Fiber.Runtime<E, A1> fiber,
4539
Unsafe unsafe) {
4640
FiberContext context = FiberContext.create();
47-
virtualField.set(fiber, context);
41+
RUNTIME_FIBER_CONTEXT.set(fiber, context);
4842
}
4943

5044
@Override
5145
public <R, E, A1> void onEnd(Exit<E, A1> value, Fiber.Runtime<E, A1> fiber, Unsafe unsafe) {}
5246

5347
@Override
5448
public <E, A1> void onSuspend(Fiber.Runtime<E, A1> fiber, Unsafe unsafe) {
55-
FiberContext context = virtualField.get(fiber);
49+
FiberContext context = RUNTIME_FIBER_CONTEXT.get(fiber);
5650
if (context != null) {
5751
context.onSuspend();
5852
}
5953
}
6054

6155
@Override
6256
public <E, A1> void onResume(Fiber.Runtime<E, A1> fiber, Unsafe unsafe) {
63-
FiberContext context = virtualField.get(fiber);
57+
FiberContext context = RUNTIME_FIBER_CONTEXT.get(fiber);
6458
if (context != null) {
6559
context.onResume();
6660
}

instrumentation/zio/zio-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/zio/v2_0/ZioRuntimeInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
package io.opentelemetry.javaagent.instrumentation.zio.v2_0;
77

8-
import static io.opentelemetry.javaagent.instrumentation.zio.v2_0.TracingSupervisor.RUNTIME_FIBER_CONTEXT;
98
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
109
import static net.bytebuddy.matcher.ElementMatchers.named;
1110

@@ -37,7 +36,7 @@ private DefaultSupervisor() {}
3736
@Advice.OnMethodExit(suppress = Throwable.class)
3837
@Advice.AssignReturned.ToReturned
3938
public static Object onExit(@Advice.Return Supervisor<?> supervisor) {
40-
return supervisor.$plus$plus(new TracingSupervisor(RUNTIME_FIBER_CONTEXT));
39+
return supervisor.$plus$plus(TracingSupervisor.INSTANCE);
4140
}
4241
}
4342
}

0 commit comments

Comments
 (0)