Skip to content

Commit b31690d

Browse files
committed
don't pass null header getter
1 parent 33536f9 commit b31690d

File tree

3 files changed

+16
-10
lines changed

3 files changed

+16
-10
lines changed

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/builder/internal/DefaultHttpServerInstrumenterBuilder.java

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import io.opentelemetry.instrumentation.api.semconv.http.HttpSpanStatusExtractor;
2929
import java.util.ArrayList;
3030
import java.util.List;
31+
import java.util.Objects;
3132
import java.util.Set;
3233
import java.util.function.Consumer;
3334
import java.util.function.Function;
@@ -53,7 +54,7 @@ public final class DefaultHttpServerInstrumenterBuilder<REQUEST, RESPONSE> {
5354
httpAttributesExtractorBuilder;
5455
private final HttpSpanNameExtractorBuilder<REQUEST> httpSpanNameExtractorBuilder;
5556

56-
@Nullable private final TextMapGetter<REQUEST> headerGetter;
57+
@Nullable private TextMapGetter<REQUEST> headerGetter;
5758
private Function<SpanNameExtractor<? super REQUEST>, ? extends SpanNameExtractor<? super REQUEST>>
5859
spanNameExtractorTransformer = Function.identity();
5960
private final HttpServerRouteBuilder<REQUEST> httpServerRouteBuilder;
@@ -65,14 +66,21 @@ public DefaultHttpServerInstrumenterBuilder(
6566
String instrumentationName,
6667
OpenTelemetry openTelemetry,
6768
HttpServerAttributesGetter<REQUEST, RESPONSE> attributesGetter,
68-
@Nullable TextMapGetter<REQUEST> headerGetter) {
69-
this.instrumentationName = instrumentationName;
70-
this.openTelemetry = openTelemetry;
69+
TextMapGetter<REQUEST> headerGetter) {
70+
this(instrumentationName, openTelemetry, attributesGetter);
71+
this.headerGetter = Objects.requireNonNull(headerGetter, "headerGetter");
72+
}
73+
74+
public DefaultHttpServerInstrumenterBuilder(
75+
String instrumentationName,
76+
OpenTelemetry openTelemetry,
77+
HttpServerAttributesGetter<REQUEST, RESPONSE> attributesGetter) {
78+
this.instrumentationName = Objects.requireNonNull(instrumentationName, "instrumentationName");
79+
this.openTelemetry = Objects.requireNonNull(openTelemetry, "openTelemetry");
80+
this.attributesGetter = Objects.requireNonNull(attributesGetter, "attributesGetter");
7181
httpAttributesExtractorBuilder = HttpServerAttributesExtractor.builder(attributesGetter);
7282
httpSpanNameExtractorBuilder = HttpSpanNameExtractor.builder(attributesGetter);
7383
httpServerRouteBuilder = HttpServerRoute.builder(attributesGetter);
74-
this.attributesGetter = attributesGetter;
75-
this.headerGetter = headerGetter;
7684
}
7785

7886
/**

instrumentation/ktor/ktor-1.0/library/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v1_0/KtorServerTracing.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,7 @@ class KtorServerTracing private constructor(
4040
DefaultHttpServerInstrumenterBuilder(
4141
INSTRUMENTATION_NAME,
4242
openTelemetry,
43-
KtorHttpServerAttributesGetter.INSTANCE,
44-
null
43+
KtorHttpServerAttributesGetter.INSTANCE
4544
)
4645
}
4746

instrumentation/ktor/ktor-2.0/library/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/server/KtorServerTracing.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ class KtorServerTracing private constructor(
5151
DefaultHttpServerInstrumenterBuilder(
5252
INSTRUMENTATION_NAME,
5353
openTelemetry,
54-
KtorHttpServerAttributesGetter.INSTANCE,
55-
null
54+
KtorHttpServerAttributesGetter.INSTANCE
5655
)
5756
}
5857

0 commit comments

Comments
 (0)