Skip to content

Commit b3233c4

Browse files
authored
Remove micrometer dependency on incubator (#13642)
1 parent a6d2a78 commit b3233c4

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

instrumentation/micrometer/micrometer-1.5/library/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ plugins {
33
}
44

55
dependencies {
6-
compileOnly("io.opentelemetry:opentelemetry-api-incubator")
7-
86
library("io.micrometer:micrometer-core:1.5.0")
97

108
testImplementation(project(":instrumentation:micrometer:micrometer-1.5:testing"))

instrumentation/micrometer/micrometer-1.5/library/src/main/java/io/opentelemetry/instrumentation/micrometer/v1_5/HistogramAdviceUtil.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
import io.micrometer.core.instrument.distribution.DistributionStatisticConfig;
1111
import io.micrometer.core.instrument.util.TimeUtils;
12-
import io.opentelemetry.api.incubator.metrics.ExtendedDoubleHistogramBuilder;
1312
import io.opentelemetry.api.metrics.DoubleHistogramBuilder;
1413
import java.util.ArrayList;
1514
import java.util.List;
@@ -28,12 +27,8 @@ static void setExplicitBucketsIfConfigured(
2827
DoubleHistogramBuilder builder,
2928
DistributionStatisticConfig config,
3029
@Nullable TimeUnit timeUnit) {
31-
if (!(builder instanceof ExtendedDoubleHistogramBuilder)) {
32-
return;
33-
}
3430
NavigableSet<Double> buckets = config.getHistogramBuckets(false);
35-
ExtendedDoubleHistogramBuilder extendedBuilder = (ExtendedDoubleHistogramBuilder) builder;
36-
extendedBuilder.setExplicitBucketBoundariesAdvice(computeBuckets(buckets, timeUnit));
31+
builder.setExplicitBucketBoundariesAdvice(computeBuckets(buckets, timeUnit));
3732
}
3833

3934
private static List<Double> computeBuckets(

0 commit comments

Comments
 (0)