post-review fixes

Author: SylvainJuge

instrumentation/vertx/vertx-redis-client-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis/RedisStandaloneConnectionInstrumentation.java

@@ -42,9 +42,15 @@ public void transform(TypeTransformer transformer) {
   @SuppressWarnings("unused")
   public static class SendAdvice {
     public static class AdviceScope {
-      public VertxRedisClientRequest otelRequest;
-      public Context context;
-      public Scope scope;
+      private final VertxRedisClientRequest otelRequest;
+      private final Context context;
+      private final Scope scope;
+
+      private AdviceScope(VertxRedisClientRequest otelRequest, Context context, Scope scope) {
+        this.otelRequest = otelRequest;
+        this.context = context;
+        this.scope = scope;
+      }
 
       @Nullable
       public static AdviceScope start(
@@ -67,11 +73,8 @@ public static AdviceScope start(
         if (!instrumenter().shouldStart(parentContext, otelRequest)) {
           return null;
         }
-        AdviceScope locals = new AdviceScope();
-        locals.otelRequest = otelRequest;
-        locals.context = instrumenter().start(parentContext, locals.otelRequest);
-        locals.scope = locals.context.makeCurrent();
-        return locals;
+        Context context = instrumenter().start(parentContext, otelRequest);
+        return new AdviceScope(otelRequest, context, context.makeCurrent());
       }
 
       @Nullable

instrumentation/vertx/vertx-sql-client/vertx-sql-client-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/QueryExecutorInstrumentation.java

@@ -104,7 +104,7 @@ public static AdviceScope start(Object queryExecutor, Object[] arguments) {
             new VertxSqlClientRequest(sql, QueryExecutorUtil.getConnectOptions(queryExecutor));
         Context parentContext = Context.current();
         if (!instrumenter().shouldStart(parentContext, otelRequest)) {
-          return new AdviceScope(callDepth, otelRequest, null, null);
+          return new AdviceScope(callDepth, null, null, null);
         }
 
         Context context = instrumenter().start(parentContext, otelRequest);