Skip to content

Commit b40f923

Browse files
authored
Rename lambda instrumentation helper class (#14371)
1 parent 4782af4 commit b40f923

File tree

22 files changed

+54
-61
lines changed

22 files changed

+54
-61
lines changed

instrumentation/aws-lambda/aws-lambda-core-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/awslambdacore/v1_0/AwsLambdaRequestHandlerInstrumentation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.hasClassesNamed;
99
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.implementsInterface;
10-
import static io.opentelemetry.javaagent.instrumentation.awslambdacore.v1_0.AwsLambdaInstrumentationHelper.flushTimeout;
11-
import static io.opentelemetry.javaagent.instrumentation.awslambdacore.v1_0.AwsLambdaInstrumentationHelper.functionInstrumenter;
10+
import static io.opentelemetry.javaagent.instrumentation.awslambdacore.v1_0.AwsLambdaSingletons.flushTimeout;
11+
import static io.opentelemetry.javaagent.instrumentation.awslambdacore.v1_0.AwsLambdaSingletons.functionInstrumenter;
1212
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
1313
import static net.bytebuddy.matcher.ElementMatchers.isPublic;
1414
import static net.bytebuddy.matcher.ElementMatchers.nameStartsWith;

instrumentation/aws-lambda/aws-lambda-core-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/awslambdacore/v1_0/AwsLambdaRequestStreamHandlerInstrumentation.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77

88
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.hasClassesNamed;
99
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.implementsInterface;
10-
import static io.opentelemetry.javaagent.instrumentation.awslambdacore.v1_0.AwsLambdaInstrumentationHelper.flushTimeout;
11-
import static io.opentelemetry.javaagent.instrumentation.awslambdacore.v1_0.AwsLambdaInstrumentationHelper.functionInstrumenter;
10+
import static io.opentelemetry.javaagent.instrumentation.awslambdacore.v1_0.AwsLambdaSingletons.flushTimeout;
11+
import static io.opentelemetry.javaagent.instrumentation.awslambdacore.v1_0.AwsLambdaSingletons.functionInstrumenter;
1212
import static net.bytebuddy.matcher.ElementMatchers.isMethod;
1313
import static net.bytebuddy.matcher.ElementMatchers.isPublic;
1414
import static net.bytebuddy.matcher.ElementMatchers.nameStartsWith;
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import io.opentelemetry.javaagent.bootstrap.internal.AgentInstrumentationConfig;
1313
import java.time.Duration;
1414

15-
public final class AwsLambdaInstrumentationHelper {
15+
public final class AwsLambdaSingletons {
1616

1717
private static final AwsLambdaFunctionInstrumenter FUNCTION_INSTRUMENTER =
1818
AwsLambdaFunctionInstrumenterFactory.createInstrumenter(GlobalOpenTelemetry.get());
@@ -31,5 +31,5 @@ public static Duration flushTimeout() {
3131
return FLUSH_TIMEOUT;
3232
}
3333

34-
private AwsLambdaInstrumentationHelper() {}
34+
private AwsLambdaSingletons() {}
3535
}

instrumentation/aws-lambda/aws-lambda-core-1.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/awslambdacore/v1_0/AwsLambdaStreamHandlerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@
3636
import org.mockito.junit.jupiter.MockitoExtension;
3737

3838
@ExtendWith(MockitoExtension.class)
39-
public class AwsLambdaStreamHandlerTest {
39+
class AwsLambdaStreamHandlerTest {
4040

4141
@RegisterExtension
42-
public static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
42+
static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
4343

4444
@Mock private Context context;
4545

instrumentation/aws-lambda/aws-lambda-core-1.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/awslambdacore/v1_0/AwsLambdaTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import org.junit.jupiter.api.Test;
2222
import org.junit.jupiter.api.extension.RegisterExtension;
2323

24-
public class AwsLambdaTest extends AbstractAwsLambdaTest {
24+
class AwsLambdaTest extends AbstractAwsLambdaTest {
2525

2626
@RegisterExtension
27-
public static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
27+
static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
2828

2929
@Override
3030
protected RequestHandler<String, String> handler() {

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/test/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/AwsLambdaStreamWrapperHttpPropagationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@
4444
key = WrappedLambda.OTEL_LAMBDA_HANDLER_ENV_KEY,
4545
value =
4646
"io.opentelemetry.instrumentation.awslambdacore.v1_0.AwsLambdaStreamWrapperHttpPropagationTest$TestRequestHandler::handleRequest")
47-
public class AwsLambdaStreamWrapperHttpPropagationTest {
47+
class AwsLambdaStreamWrapperHttpPropagationTest {
4848

4949
@RegisterExtension
50-
public static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
50+
static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
5151

5252
@Mock private Context context;
5353

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/test/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/AwsLambdaStreamWrapperTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,10 @@
4343
key = WrappedLambda.OTEL_LAMBDA_HANDLER_ENV_KEY,
4444
value =
4545
"io.opentelemetry.instrumentation.awslambdacore.v1_0.AwsLambdaStreamWrapperTest$TestRequestHandler::handleRequest")
46-
public class AwsLambdaStreamWrapperTest {
46+
class AwsLambdaStreamWrapperTest {
4747

4848
@RegisterExtension
49-
public static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
49+
static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
5050

5151
@Mock private Context context;
5252

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/test/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/AwsLambdaTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
import io.opentelemetry.sdk.OpenTelemetrySdk;
1313
import org.junit.jupiter.api.extension.RegisterExtension;
1414

15-
public class AwsLambdaTest extends AbstractAwsLambdaTest {
15+
class AwsLambdaTest extends AbstractAwsLambdaTest {
1616

1717
@RegisterExtension
18-
public static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
18+
static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
1919

2020
@Override
2121
protected RequestHandler<String, String> handler() {

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/test/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/internal/ApiGatewayProxyRequestTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ void resetOpenTelemetry() {
3030
}
3131

3232
@Test
33-
public void shouldCreateNoopRequestIfNoPropagatorsSet() throws IOException {
33+
void shouldCreateNoopRequestIfNoPropagatorsSet() throws IOException {
3434
// given
3535
InputStream mock = mock(InputStream.class);
3636
GlobalOpenTelemetry.set(OpenTelemetry.noop());
@@ -42,7 +42,7 @@ public void shouldCreateNoopRequestIfNoPropagatorsSet() throws IOException {
4242
}
4343

4444
@Test
45-
public void shouldCreateNoopRequestIfXrayPropagatorsSet() throws IOException {
45+
void shouldCreateNoopRequestIfXrayPropagatorsSet() throws IOException {
4646
// given
4747
InputStream mock = mock(InputStream.class);
4848
GlobalOpenTelemetry.set(
@@ -55,7 +55,7 @@ public void shouldCreateNoopRequestIfXrayPropagatorsSet() throws IOException {
5555
}
5656

5757
@Test
58-
public void shouldUseStreamMarkingIfHttpPropagatorsSet() throws IOException {
58+
void shouldUseStreamMarkingIfHttpPropagatorsSet() throws IOException {
5959
// given
6060
InputStream mock = mock(InputStream.class);
6161
when(mock.markSupported()).thenReturn(true);
@@ -70,7 +70,7 @@ public void shouldUseStreamMarkingIfHttpPropagatorsSet() throws IOException {
7070
}
7171

7272
@Test
73-
public void shouldUseNoopIfMarkingNotAvailableAndHttpPropagatorsSet() throws IOException {
73+
void shouldUseNoopIfMarkingNotAvailableAndHttpPropagatorsSet() throws IOException {
7474
// given
7575
InputStream mock = mock(InputStream.class);
7676
when(mock.markSupported()).thenReturn(false);

instrumentation/aws-lambda/aws-lambda-core-1.0/library/src/test/java/io/opentelemetry/instrumentation/awslambdacore/v1_0/internal/HeadersFactoryTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
class HeadersFactoryTest {
1818

1919
@Test
20-
public void shouldReadHeadersFromStream() {
20+
void shouldReadHeadersFromStream() {
2121
// given
2222
String json =
2323
"{"
@@ -40,7 +40,7 @@ public void shouldReadHeadersFromStream() {
4040
}
4141

4242
@Test
43-
public void shouldReturnNullIfNoHeadersInStream() {
43+
void shouldReturnNullIfNoHeadersInStream() {
4444
// given
4545
String json = "{\"something\" : \"else\"}";
4646
InputStream inputStream = new ByteArrayInputStream(json.getBytes(Charset.defaultCharset()));

0 commit comments

Comments
 (0)