tomcat.request.duration.total -> tomcat.request.duration.sum

Author: robsunday

instrumentation/jmx-metrics/library/src/main/resources/jmx/rules/tomcat.yaml

@@ -27,7 +27,7 @@ rules:
         unit: s
         desc: The longest request processing time.
       processingTime:
-        metric: request.duration.total
+        metric: request.duration.sum
         type: counter
         sourceUnit: ms
         unit: s

instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/rules/TomcatIntegrationTest.java

@@ -89,7 +89,7 @@ private static MetricsVerifier createMetricsVerifier() {
                     .isGauge()
                     .hasDataPointsWithOneAttribute(requestProcessorNameAttribute))
         .add(
-            "tomcat.request.duration.total",
+            "tomcat.request.duration.sum",
             metric ->
                 metric
                     .hasDescription("Total time of processing all requests.")

instrumentation/jmx-metrics/library/tomcat.md

@@ -2,15 +2,15 @@
 
 Here is the list of metrics based on MBeans exposed by Tomcat.
 
-| Metric Name                   | Type          | Attributes                                          | Description                                |
-|-------------------------------|---------------|-----------------------------------------------------|--------------------------------------------|
-| tomcat.session.active.count   | UpDownCounter | tomcat.context                                      | The number of currently active sessions.   |
-| tomcat.session.active.limit   | UpDownCounter | tomcat.context                                      | Maximum number of active sessions.         |
-| tomcat.error.count            | Counter       | tomcat.request_processor.name                       | The number of errors.                      |
-| tomcat.request.count          | Counter       | tomcat.request_processor.name                       | The number of requests processed.          |
-| tomcat.request.duration.max   | Gauge         | tomcat.request_processor.name                       | The longest request processing time.       |
-| tomcat.request.duration.total | Counter       | tomcat.request_processor.name                       | Total time of processing all requests.     |
-| tomcat.network.io             | Counter       | tomcat.request_processor.name, network.io.direction | The number of bytes transmitted.           |
-| tomcat.thread.count           | UpDownCounter | tomcat.thread_pool.name                             | Total thread count of the thread pool.     |
-| tomcat.thread.max             | UpDownCounter | tomcat.thread_pool.name                             | Maximum thread count of the thread pool.   |
-| tomcat.thread.busy.count      | UpDownCounter | tomcat.thread_pool.name                             | Number of busy threads in the thread pool. |
+| Metric Name                 | Type          | Attributes                                          | Description                                |
+|-----------------------------|---------------|-----------------------------------------------------|--------------------------------------------|
+| tomcat.session.active.count | UpDownCounter | tomcat.context                                      | The number of currently active sessions.   |
+| tomcat.session.active.limit | UpDownCounter | tomcat.context                                      | Maximum number of active sessions.         |
+| tomcat.error.count          | Counter       | tomcat.request_processor.name                       | The number of errors.                      |
+| tomcat.request.count        | Counter       | tomcat.request_processor.name                       | The number of requests processed.          |
+| tomcat.request.duration.max | Gauge         | tomcat.request_processor.name                       | The longest request processing time.       |
+| tomcat.request.duration.sum | Counter       | tomcat.request_processor.name                       | Total time of processing all requests.     |
+| tomcat.network.io           | Counter       | tomcat.request_processor.name, network.io.direction | The number of bytes transmitted.           |
+| tomcat.thread.count         | UpDownCounter | tomcat.thread_pool.name                             | Total thread count of the thread pool.     |
+| tomcat.thread.max           | UpDownCounter | tomcat.thread_pool.name                             | Maximum thread count of the thread pool.   |
+| tomcat.thread.busy.count    | UpDownCounter | tomcat.thread_pool.name                             | Number of busy threads in the thread pool. |