Skip to content

Commit b774178

Browse files
committed
simplify
1 parent 10ca2ea commit b774178

File tree

2 files changed

+5
-6
lines changed
  • instrumentation/vertx/vertx-redis-client-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis
  • testing-common/src/main/java/io/opentelemetry/instrumentation/testing/junit/db

2 files changed

+5
-6
lines changed

instrumentation/vertx/vertx-redis-client-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/redis/VertxRedisClientTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010

1111
import io.opentelemetry.api.common.AttributeKey;
1212
import io.opentelemetry.api.trace.SpanKind;
13+
import io.opentelemetry.instrumentation.api.internal.SemconvStability;
1314
import io.opentelemetry.instrumentation.testing.junit.AgentInstrumentationExtension;
1415
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
1516
import io.opentelemetry.instrumentation.testing.junit.db.SemconvStabilityUtil;
@@ -202,7 +203,8 @@ void commandWithNoArguments() throws Exception {
202203
}
203204

204205
private static AttributeAssertion[] redisSpanAttributes(String operation, String statement) {
205-
if (SemconvStabilityUtil.isStable()) {
206+
// not testing database/dup
207+
if (SemconvStability.emitStableDatabaseSemconv()) {
206208
return new AttributeAssertion[] {
207209
equalTo(DbIncubatingAttributes.DB_SYSTEM, "redis"),
208210
equalTo(AttributeKey.stringKey("db.query.text"), statement),

testing-common/src/main/java/io/opentelemetry/instrumentation/testing/junit/db/SemconvStabilityUtil.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,10 @@ private static <T> void addKey(
4747

4848
@SuppressWarnings("unchecked")
4949
public static <T> AttributeKey<T> getAttributeKey(AttributeKey<T> oldKey) {
50-
if (isStable()) {
50+
// not testing database/dup
51+
if (SemconvStability.emitStableDatabaseSemconv()) {
5152
return (AttributeKey<T>) oldToNewMap.get(oldKey);
5253
}
5354
return oldKey;
5455
}
55-
56-
public static boolean isStable() {
57-
return SemconvStability.emitStableDatabaseSemconv();
58-
}
5956
}

0 commit comments

Comments
 (0)