Skip to content

Commit b7a8836

Browse files
committed
pr review
1 parent b1aa571 commit b7a8836

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

javaagent-tooling/src/test/java/io/opentelemetry/javaagent/tooling/bytebuddy/matcher/ExtendsClassMatcherTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import static io.opentelemetry.javaagent.extension.matcher.AgentElementMatchers.extendsClass;
99
import static net.bytebuddy.matcher.ElementMatchers.named;
1010
import static org.assertj.core.api.Assertions.assertThat;
11-
import static org.assertj.core.api.Assertions.assertThatCode;
1211
import static org.mockito.Mockito.mock;
1312
import static org.mockito.Mockito.when;
1413

@@ -64,7 +63,7 @@ void testTraversalExceptions() {
6463
boolean result = extendsClass(named(Object.class.getName())).matches(type);
6564

6665
assertThat(result).isFalse();
67-
assertThatCode(() -> extendsClass(named(Object.class.getName())).matches(type))
68-
.doesNotThrowAnyException();
66+
// should not throw
67+
extendsClass(named(Object.class.getName())).matches(type);
6968
}
7069
}

javaagent-tooling/src/test/java/io/opentelemetry/javaagent/tooling/bytebuddy/matcher/ThrowOnFirstElement.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
import java.util.Iterator;
99

10-
public class ThrowOnFirstElement implements Iterator<Object> {
10+
class ThrowOnFirstElement implements Iterator<Object> {
1111
private int current = 0;
1212

1313
@Override

0 commit comments

Comments
 (0)