Skip to content

Commit b910574

Browse files
committed
add http.response.status_code
1 parent fe94d7c commit b910574

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

instrumentation/aws-lambda/aws-lambda-events-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/awslambdaevents/v2_2/AwsLambdaRequestHandlerInstrumentation.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ public static void onEnter(
9494
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
9595
public static void stopSpan(
9696
@Advice.Argument(value = 0, typing = Typing.DYNAMIC) Object arg,
97+
@Advice.Return Object result,
9798
@Advice.Thrown Throwable throwable,
9899
@Advice.Local("otelInput") AwsLambdaRequest input,
99100
@Advice.Local("otelFunctionContext") io.opentelemetry.context.Context functionContext,
@@ -110,7 +111,7 @@ public static void stopSpan(
110111
if (functionScope != null) {
111112
functionScope.close();
112113
AwsLambdaInstrumentationHelper.functionInstrumenter()
113-
.end(functionContext, input, null, throwable);
114+
.end(functionContext, input, result, throwable);
114115
}
115116

116117
OpenTelemetrySdkAccess.forceFlush(1, TimeUnit.SECONDS);

instrumentation/aws-lambda/aws-lambda-events-2.2/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/awslambdaevents/v2_2/AwsLambdaApiGatewayHandlerTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ void tracedWithHttpPropagation() {
8686
equalTo(FaasIncubatingAttributes.FAAS_TRIGGER, "http"),
8787
equalTo(HttpAttributes.HTTP_REQUEST_METHOD, "PUT"),
8888
equalTo(UserAgentAttributes.USER_AGENT_ORIGINAL, "Clever Client"),
89-
equalTo(UrlAttributes.URL_FULL, "http://localhost:2024/hello/world"))));
89+
equalTo(UrlAttributes.URL_FULL, "http://localhost:2024/hello/world"),
90+
equalTo(HttpAttributes.HTTP_RESPONSE_STATUS_CODE, 201L))));
9091
}
9192

9293
public static class TestRequestHandlerApiGateway

0 commit comments

Comments
 (0)