Skip to content

Commit b9a24b1

Browse files
committed
Remove incorrect API of Dubbo
1 parent ab09fce commit b9a24b1

File tree

2 files changed

+0
-27
lines changed

2 files changed

+0
-27
lines changed

instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/DubboTelemetry.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,6 @@ public static DubboTelemetryBuilder builder(OpenTelemetry openTelemetry) {
3535
this.clientInstrumenter = clientInstrumenter;
3636
}
3737

38-
/**
39-
* Returns a new Dubbo {@link Filter} that traces Dubbo RPC invocations.
40-
*
41-
* @deprecated Use {@link #newClientFilter} and {@link #newServerFilter} instead.
42-
*/
43-
@Deprecated
44-
public Filter newFilter() {
45-
return TracingFilter.newFilter(serverInstrumenter, clientInstrumenter);
46-
}
47-
4838
/** Returns a new Dubbo client {@link Filter} that traces Dubbo RPC invocations. */
4939
public Filter newClientFilter() {
5040
return TracingFilter.newClientFilter(clientInstrumenter);

instrumentation/apache-dubbo-2.7/library-autoconfigure/src/main/java/io/opentelemetry/instrumentation/apachedubbo/v2_7/TracingFilter.java

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -49,23 +49,6 @@ public boolean isClientSide(RpcContext rpcContext) {
4949
});
5050
}
5151

52-
static TracingFilter newFilter(
53-
Instrumenter<DubboRequest, Result> serverInstrumenter,
54-
Instrumenter<DubboRequest, Result> clientInstrumenter) {
55-
return new TracingFilter(
56-
new InstrumenterSupplier() {
57-
@Override
58-
public Instrumenter<DubboRequest, Result> get(RpcContext rpcContext) {
59-
return rpcContext.isConsumerSide() ? clientInstrumenter : serverInstrumenter;
60-
}
61-
62-
@Override
63-
public boolean isClientSide(RpcContext rpcContext) {
64-
return rpcContext.isConsumerSide();
65-
}
66-
});
67-
}
68-
6952
@Override
7053
@SuppressWarnings("deprecation") // deprecation for RpcContext.getContext()
7154
public Result invoke(Invoker<?> invoker, Invocation invocation) {

0 commit comments

Comments
 (0)