configure logging span exporter

Author: zeitlinger

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/logging/LoggingExporterAutoConfiguration.java

@@ -0,0 +1,38 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.logging;
+
+import io.opentelemetry.exporter.logging.LoggingSpanExporter;
+import io.opentelemetry.instrumentation.logging.LoggingSpanExporterConfigurer;
+import io.opentelemetry.instrumentation.spring.autoconfigure.internal.SdkEnabled;
+import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
+import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Conditional;
+import org.springframework.context.annotation.Configuration;
+
+/**
+ * This class is internal and is hence not for public use. Its APIs are unstable and can change at
+ * any time.
+ */
+@Conditional(SdkEnabled.class)
+// for backward compatibility with declarative configuration
+@ConditionalOnProperty(name = "otel.log_level", havingValue = "debug")
+@ConditionalOnClass(LoggingSpanExporter.class)
+@Configuration
+public class LoggingExporterAutoConfiguration {
+
+  @Bean
+  public AutoConfigurationCustomizerProvider loggingOtelCustomizer() {
+    return p ->
+        p.addTracerProviderCustomizer(
+            (builder, config) -> {
+              LoggingSpanExporterConfigurer.enableLoggingExporter(builder, config);
+              return builder;
+            });
+  }
+}

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentTracerProviderConfigurer.java

@@ -5,19 +5,17 @@
 
 package io.opentelemetry.javaagent.tooling;
 
+import static io.opentelemetry.instrumentation.logging.LoggingSpanExporterConfigurer.enableLoggingExporter;
 import static io.opentelemetry.javaagent.tooling.AgentInstaller.JAVAAGENT_ENABLED_CONFIG;
-import static java.util.Collections.emptyList;
 
 import com.google.auto.service.AutoService;
 import com.google.errorprone.annotations.CanIgnoreReturnValue;
-import io.opentelemetry.exporter.logging.LoggingSpanExporter;
 import io.opentelemetry.instrumentation.thread.AddThreadDetailsSpanProcessor;
 import io.opentelemetry.javaagent.tooling.config.AgentConfig;
 import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizer;
 import io.opentelemetry.sdk.autoconfigure.spi.AutoConfigurationCustomizerProvider;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
 import io.opentelemetry.sdk.trace.SdkTracerProviderBuilder;
-import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor;
 
 @AutoService(AutoConfigurationCustomizerProvider.class)
 public class AgentTracerProviderConfigurer implements AutoConfigurationCustomizerProvider {
@@ -41,22 +39,10 @@ private static SdkTracerProviderBuilder configure(
       sdkTracerProviderBuilder.addSpanProcessor(new AddThreadDetailsSpanProcessor());
     }
 
-    maybeEnableLoggingExporter(sdkTracerProviderBuilder, config);
-
-    return sdkTracerProviderBuilder;
-  }
-
-  private static void maybeEnableLoggingExporter(
-      SdkTracerProviderBuilder builder, ConfigProperties config) {
     if (AgentConfig.isDebugModeEnabled(config)) {
-      // don't install another instance if the user has already explicitly requested it.
-      if (loggingExporterIsNotAlreadyConfigured(config)) {
-        builder.addSpanProcessor(SimpleSpanProcessor.create(LoggingSpanExporter.create()));
-      }
+      enableLoggingExporter(sdkTracerProviderBuilder, config);
     }
-  }
 
-  private static boolean loggingExporterIsNotAlreadyConfigured(ConfigProperties config) {
-    return !config.getList("otel.traces.exporter", emptyList()).contains("logging");
+    return sdkTracerProviderBuilder;
   }
 }

sdk-autoconfigure-support/build.gradle.kts

@@ -6,6 +6,7 @@ plugins {
 group = "io.opentelemetry.instrumentation"
 
 dependencies {
+  compileOnly("io.opentelemetry:opentelemetry-exporter-logging")
   api("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
 
   compileOnly("com.google.code.findbugs:annotations")

sdk-autoconfigure-support/src/main/java/io/opentelemetry/instrumentation/logging/LoggingSpanExporterConfigurer.java

@@ -0,0 +1,25 @@
+package io.opentelemetry.instrumentation.logging;
+
+import static java.util.Collections.emptyList;
+
+import io.opentelemetry.exporter.logging.LoggingSpanExporter;
+import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
+import io.opentelemetry.sdk.trace.SdkTracerProviderBuilder;
+import io.opentelemetry.sdk.trace.export.SimpleSpanProcessor;
+
+public class LoggingSpanExporterConfigurer {
+
+  private LoggingSpanExporterConfigurer() {}
+
+  public static void enableLoggingExporter(
+      SdkTracerProviderBuilder builder, ConfigProperties config) {
+    // don't install another instance if the user has already explicitly requested it.
+    if (loggingExporterIsNotAlreadyConfigured(config)) {
+      builder.addSpanProcessor(SimpleSpanProcessor.create(LoggingSpanExporter.create()));
+    }
+  }
+
+  private static boolean loggingExporterIsNotAlreadyConfigured(ConfigProperties config) {
+    return !config.getList("otel.traces.exporter", emptyList()).contains("logging");
+  }
+}