Skip to content

Commit bc177b4

Browse files
committed
use bridge
1 parent 3494ab2 commit bc177b4

File tree

15 files changed

+30
-90
lines changed

15 files changed

+30
-90
lines changed

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/InstrumentationConfig.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,6 @@ default List<String> getList(String name) {
119119
* Returns a {@link DeclarativeConfigProperties} for the given node name, which is usually an
120120
* instrumentation name. If declarative configuration is not used, a bridge to ConfigProperties is
121121
*
122-
*
123122
* <p>Declarative configuration is used to configure instrumentation properties in a declarative
124123
* way, such as through YAML or JSON files.
125124
*

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ public ConfigProvider configProvider(ConfigProperties properties) {
153153
@Bean
154154
public InstrumentationConfig instrumentationConfig(
155155
ConfigProperties properties, ConfigProvider configProvider) {
156-
return new ConfigPropertiesBridge(properties, configProvider);
156+
return new ConfigPropertiesBridge(properties, configProvider, false);
157157
}
158158
}
159159

@@ -198,7 +198,7 @@ public ConfigProperties otelProperties(ConfigProvider configProvider) {
198198
@Bean
199199
public InstrumentationConfig instrumentationConfig(
200200
ConfigProperties properties, ConfigProvider configProvider) {
201-
return new ConfigPropertiesBridge(properties, configProvider);
201+
return new ConfigPropertiesBridge(properties, configProvider, true);
202202
}
203203

204204
@Bean
@@ -245,7 +245,7 @@ public ConfigProvider configProvider() {
245245
@Bean
246246
public InstrumentationConfig instrumentationConfig(
247247
ConfigProperties properties, ConfigProvider configProvider) {
248-
return new ConfigPropertiesBridge(properties, configProvider);
248+
return new ConfigPropertiesBridge(properties, configProvider, false);
249249
}
250250

251251
@Configuration
@@ -292,7 +292,7 @@ static class FallbackInstrumentationConfig {
292292
@Bean
293293
public InstrumentationConfig instrumentationConfig(
294294
ConfigProperties properties, ConfigProvider configProvider) {
295-
return new ConfigPropertiesBridge(properties, configProvider);
295+
return new ConfigPropertiesBridge(properties, configProvider, false);
296296
}
297297
}
298298

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/properties/ConfigPropertiesBridge.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,7 @@
55

66
package io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties;
77

8-
import static io.opentelemetry.api.incubator.config.DeclarativeConfigProperties.empty;
9-
108
import io.opentelemetry.api.incubator.config.ConfigProvider;
11-
import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
12-
import io.opentelemetry.api.incubator.config.InstrumentationConfigUtil;
139
import io.opentelemetry.instrumentation.api.incubator.config.internal.InstrumentationConfig;
1410
import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
1511
import io.opentelemetry.sdk.autoconfigure.spi.ConfigurationException;

instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/scheduling/SchedulingInstrumentationAspectTest.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,19 @@
66
package io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.scheduling;
77

88
import static io.opentelemetry.api.trace.SpanKind.INTERNAL;
9+
import static io.opentelemetry.instrumentation.spring.autoconfigure.internal.AbstractKafkaInstrumentationAutoConfigurationTest.EMPTY_INSTRUMENTATION_CONFIG;
910
import static org.assertj.core.api.Assertions.assertThatThrownBy;
1011

1112
import io.opentelemetry.api.OpenTelemetry;
12-
import io.opentelemetry.api.incubator.config.ConfigProvider;
1313
import io.opentelemetry.api.trace.Span;
1414
import io.opentelemetry.api.trace.Tracer;
1515
import io.opentelemetry.context.Context;
1616
import io.opentelemetry.context.Scope;
1717
import io.opentelemetry.instrumentation.api.incubator.config.internal.InstrumentationConfig;
18-
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.ConfigPropertiesBridge;
1918
import io.opentelemetry.instrumentation.testing.junit.LibraryInstrumentationExtension;
2019
import io.opentelemetry.instrumentation.testing.junit.code.SemconvCodeStabilityUtil;
21-
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
2220
import io.opentelemetry.sdk.testing.assertj.AttributeAssertion;
2321
import io.opentelemetry.sdk.trace.data.StatusData;
24-
import java.util.Collections;
2522
import java.util.List;
2623
import org.junit.jupiter.api.BeforeEach;
2724
import org.junit.jupiter.api.DisplayName;
@@ -56,11 +53,7 @@ void setup() {
5653
factory.setTarget(unproxiedTester);
5754

5855
SpringSchedulingInstrumentationAspect aspect =
59-
newAspect(
60-
testing.getOpenTelemetry(),
61-
new ConfigPropertiesBridge(
62-
DefaultConfigProperties.createFromMap(Collections.emptyMap()),
63-
ConfigProvider.noop()));
56+
newAspect(testing.getOpenTelemetry(), EMPTY_INSTRUMENTATION_CONFIG);
6457
factory.addAspect(aspect);
6558

6659
schedulingTester = factory.getProxy();

instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/scheduling/SchedulingInstrumentationAutoConfigurationTest.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,11 @@
55

66
package io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.scheduling;
77

8+
import static io.opentelemetry.instrumentation.spring.autoconfigure.internal.AbstractKafkaInstrumentationAutoConfigurationTest.EMPTY_INSTRUMENTATION_CONFIG;
89
import static org.assertj.core.api.Assertions.assertThat;
910

1011
import io.opentelemetry.api.OpenTelemetry;
11-
import io.opentelemetry.api.incubator.config.ConfigProvider;
1212
import io.opentelemetry.instrumentation.api.incubator.config.internal.InstrumentationConfig;
13-
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.ConfigPropertiesBridge;
14-
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
15-
import java.util.Collections;
1613
import org.junit.jupiter.api.Test;
1714
import org.springframework.boot.autoconfigure.AutoConfigurations;
1815
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
@@ -21,12 +18,7 @@ class SchedulingInstrumentationAutoConfigurationTest {
2118
private final ApplicationContextRunner runner =
2219
new ApplicationContextRunner()
2320
.withBean(OpenTelemetry.class, OpenTelemetry::noop)
24-
.withBean(
25-
InstrumentationConfig.class,
26-
() ->
27-
new ConfigPropertiesBridge(
28-
DefaultConfigProperties.createFromMap(Collections.emptyMap()),
29-
ConfigProvider.noop()))
21+
.withBean(InstrumentationConfig.class, () -> EMPTY_INSTRUMENTATION_CONFIG)
3022
.withConfiguration(
3123
AutoConfigurations.of(SpringSchedulingInstrumentationAutoConfiguration.class));
3224

instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/webflux/SpringWebfluxInstrumentationAutoConfigurationTest.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,11 @@
55

66
package io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.webflux;
77

8+
import static io.opentelemetry.instrumentation.spring.autoconfigure.internal.AbstractKafkaInstrumentationAutoConfigurationTest.EMPTY_INSTRUMENTATION_CONFIG;
89
import static org.assertj.core.api.Assertions.assertThat;
910

1011
import io.opentelemetry.api.OpenTelemetry;
11-
import io.opentelemetry.api.incubator.config.ConfigProvider;
1212
import io.opentelemetry.instrumentation.api.incubator.config.internal.InstrumentationConfig;
13-
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.ConfigPropertiesBridge;
14-
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
15-
import java.util.Collections;
1613
import org.junit.jupiter.api.Test;
1714
import org.springframework.boot.autoconfigure.AutoConfigurations;
1815
import org.springframework.boot.test.context.runner.ApplicationContextRunner;
@@ -22,12 +19,7 @@ class SpringWebfluxInstrumentationAutoConfigurationTest {
2219
private final ApplicationContextRunner contextRunner =
2320
new ApplicationContextRunner()
2421
.withBean(OpenTelemetry.class, OpenTelemetry::noop)
25-
.withBean(
26-
InstrumentationConfig.class,
27-
() ->
28-
new ConfigPropertiesBridge(
29-
DefaultConfigProperties.createFromMap(Collections.emptyMap()),
30-
ConfigProvider.noop()))
22+
.withBean(InstrumentationConfig.class, () -> EMPTY_INSTRUMENTATION_CONFIG)
3123
.withConfiguration(
3224
AutoConfigurations.of(SpringWebfluxInstrumentationAutoConfiguration.class));
3325

instrumentation/spring/spring-boot-autoconfigure/src/test/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/webmvc/SpringWebMvcInstrumentation5AutoConfigurationTest.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,12 @@
55

66
package io.opentelemetry.instrumentation.spring.autoconfigure.internal.instrumentation.webmvc;
77

8+
import static io.opentelemetry.instrumentation.spring.autoconfigure.internal.AbstractKafkaInstrumentationAutoConfigurationTest.EMPTY_INSTRUMENTATION_CONFIG;
89
import static org.assertj.core.api.Assertions.assertThat;
910
import static org.junit.jupiter.api.Assumptions.assumeFalse;
1011

1112
import io.opentelemetry.api.OpenTelemetry;
12-
import io.opentelemetry.api.incubator.config.ConfigProvider;
1313
import io.opentelemetry.instrumentation.api.incubator.config.internal.InstrumentationConfig;
14-
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.ConfigPropertiesBridge;
15-
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
16-
import java.util.Collections;
1714
import javax.servlet.Filter;
1815
import org.junit.jupiter.api.BeforeEach;
1916
import org.junit.jupiter.api.Test;
@@ -25,12 +22,7 @@ class SpringWebMvcInstrumentation5AutoConfigurationTest {
2522
private final ApplicationContextRunner contextRunner =
2623
new ApplicationContextRunner()
2724
.withBean(OpenTelemetry.class, OpenTelemetry::noop)
28-
.withBean(
29-
InstrumentationConfig.class,
30-
() ->
31-
new ConfigPropertiesBridge(
32-
DefaultConfigProperties.createFromMap(Collections.emptyMap()),
33-
ConfigProvider.noop()))
25+
.withBean(InstrumentationConfig.class, () -> EMPTY_INSTRUMENTATION_CONFIG)
3426
.withConfiguration(
3527
AutoConfigurations.of(SpringWebMvc5InstrumentationAutoConfiguration.class));
3628

instrumentation/spring/spring-boot-autoconfigure/src/testSpring3/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/web/RestClientInstrumentationAutoConfigurationTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ class RestClientInstrumentationAutoConfigurationTest {
2828
() ->
2929
new ConfigPropertiesBridge(
3030
DefaultConfigProperties.createFromMap(Collections.emptyMap()),
31-
ConfigProvider.noop()))
31+
ConfigProvider.noop(),
32+
false))
3233
.withBean(RestClient.class, RestClient::create)
3334
.withConfiguration(
3435
AutoConfigurations.of(RestClientInstrumentationAutoConfiguration.class));

instrumentation/spring/spring-boot-autoconfigure/src/testSpring3/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/instrumentation/webmvc/SpringWebMvcInstrumentation6AutoConfigurationTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ class SpringWebMvcInstrumentation6AutoConfigurationTest {
3030
() ->
3131
new ConfigPropertiesBridge(
3232
DefaultConfigProperties.createFromMap(Collections.emptyMap()),
33-
ConfigProvider.noop()))
33+
ConfigProvider.noop(),
34+
false))
3435
.withConfiguration(
3536
AutoConfigurations.of(SpringWebMvc6InstrumentationAutoConfiguration.class));
3637

instrumentation/spring/spring-boot-autoconfigure/testing/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/internal/AbstractJdbcInstrumentationAutoConfigurationTest.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,14 @@
55

66
package io.opentelemetry.instrumentation.spring.autoconfigure.internal;
77

8+
import static io.opentelemetry.instrumentation.spring.autoconfigure.internal.AbstractKafkaInstrumentationAutoConfigurationTest.EMPTY_INSTRUMENTATION_CONFIG;
89
import static io.opentelemetry.instrumentation.testing.junit.db.SemconvStabilityUtil.maybeStable;
910
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_STATEMENT;
10-
import static java.util.Collections.emptyMap;
1111
import static org.assertj.core.api.Assertions.assertThat;
1212

1313
import io.opentelemetry.api.OpenTelemetry;
14-
import io.opentelemetry.api.incubator.config.ConfigProvider;
1514
import io.opentelemetry.instrumentation.api.incubator.config.internal.InstrumentationConfig;
16-
import io.opentelemetry.instrumentation.spring.autoconfigure.internal.properties.ConfigPropertiesBridge;
1715
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
18-
import io.opentelemetry.sdk.autoconfigure.spi.internal.DefaultConfigProperties;
1916
import java.sql.Connection;
2017
import java.sql.Statement;
2118
import javax.sql.DataSource;
@@ -33,11 +30,7 @@ public abstract class AbstractJdbcInstrumentationAutoConfigurationTest {
3330

3431
private final ApplicationContextRunner contextRunner =
3532
new ApplicationContextRunner()
36-
.withBean(
37-
InstrumentationConfig.class,
38-
() ->
39-
new ConfigPropertiesBridge(
40-
DefaultConfigProperties.createFromMap(emptyMap()), ConfigProvider.noop()))
33+
.withBean(InstrumentationConfig.class, () -> EMPTY_INSTRUMENTATION_CONFIG)
4134
.withConfiguration(autoConfigurations())
4235
.withBean("openTelemetry", OpenTelemetry.class, testing()::getOpenTelemetry);
4336

0 commit comments

Comments
 (0)