Skip to content

Commit bc785b9

Browse files
committed
fix typos and comments
1 parent b77428c commit bc785b9

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

instrumentation/internal/internal-lambda/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/lambda/LambdaInstrumentationModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public boolean defaultEnabled(ConfigProperties config) {
3131
@Override
3232
public List<String> injectedClassNames() {
3333
return Collections.singletonList(
34-
"io.opentelemetry.javaagent.instrumentation.internal.lambda.LambdaTransformer");
34+
"io.opentelemetry.javaagent.instrumentation.internal.lambda.LambdaTransformerHelper");
3535
}
3636

3737
@Override

instrumentation/internal/internal-lambda/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/lambda/LambdaTransformerHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public static byte[] transform(byte[] classBytes, String slashClassName, Class<?
2424
if (InjectedClassHelper.isHelperClass(targetClass)) {
2525
return classBytes;
2626
}
27-
LambdaTransformer transformer = LambdaTransformerHolder.setLambdaTransformer();
27+
LambdaTransformer transformer = LambdaTransformerHolder.getLambdaTransformer();
2828
if (transformer == null) {
2929
return classBytes;
3030
}

javaagent-bootstrap/src/main/java/io/opentelemetry/javaagent/bootstrap/LambdaTransformerHolder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public final class LambdaTransformerHolder {
1919
*
2020
* @return class transformer for defining lambdas
2121
*/
22-
public static LambdaTransformer setLambdaTransformer() {
22+
public static LambdaTransformer getLambdaTransformer() {
2323
return lambdaTransformer;
2424
}
2525

javaagent-tooling/javaagent-tooling-java9/src/main/java/io/opentelemetry/javaagent/tooling/Java9LambdaTransformer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ public Java9LambdaTransformer(ClassFileTransformer delegate) {
2222
public byte[] transform(String className, Class<?> targetClass, byte[] classfileBuffer)
2323
throws IllegalClassFormatException {
2424

25-
// lambda instrumentation happens only when the lambda is defined, thus the classBeingRedefined
26-
// must be null otherwise we get a partial instrumentation, for example virtual fields are not
27-
// properly applied
25+
// lambda instrumentation happens only when the lambda is being defined, so the targetClass
26+
// argument should not be passed to the transformer otherwise we get a partial instrumentation,
27+
// for example virtual fields are not properly applied
2828
return delegate.transform(
2929
targetClass.getModule(),
3030
targetClass.getClassLoader(),

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/Java8LambdaTransformer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ public Java8LambdaTransformer(ClassFileTransformer delegate) {
2222
public byte[] transform(String className, Class<?> targetClass, byte[] classfileBuffer)
2323
throws IllegalClassFormatException {
2424

25-
// lambda instrumentation happens only when the lambda is defined, thus the classBeingRedefined
26-
// must be null otherwise we get a partial instrumentation, for example virtual fields are not
27-
// properly applied.
25+
// lambda instrumentation happens only when the lambda is being defined, so the targetClass
26+
// argument should not be passed to the transformer otherwise we get a partial instrumentation,
27+
// for example virtual fields are not properly applied
2828
return delegate.transform(targetClass.getClassLoader(), className, null, null, classfileBuffer);
2929
}
3030
}

0 commit comments

Comments
 (0)