Skip to content

Commit bd70195

Browse files
committed
add TODO + spotless reformat
1 parent 0f20c60 commit bd70195

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/instrumentation/internal/ExperimentalInstrumentationModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,8 @@ default List<String> agentPackagesToHide() {
7373
*
7474
* @return map of module to open as key, list of packages as value.
7575
*/
76+
// TODO: when moving this method outside of experimental API, we need to decide using JavaModule
77+
// instance or a class FQN in the map entry, as it could lead to some limitations
7678
default Map<JavaModule, List<String>> jpmsModulesToOpen() {
7779
return Collections.emptyMap();
7880
}

javaagent-tooling/javaagent-tooling-java9/src/main/java/io/opentelemetry/javaagent/tooling/ModuleOpener.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,8 @@ private ModuleOpener() {}
4040
* Opens JPMS module to a class loader unnamed module
4141
*
4242
* @param targetModule target module
43-
* @param openTo class loader to open module for, {@literal null} to use the unnamed module of bootstrap classloader.
43+
* @param openTo class loader to open module for, {@literal null} to use the unnamed module of
44+
* bootstrap classloader.
4445
* @param packagesToOpen packages to open
4546
*/
4647
public static void open(

0 commit comments

Comments
 (0)