Skip to content

Commit bd7c14e

Browse files
committed
hopefully fix shading
1 parent ceb08b6 commit bd7c14e

File tree

3 files changed

+33
-4
lines changed

3 files changed

+33
-4
lines changed

instrumentation/internal/internal-class-loader/javaagent-integration-tests/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ dependencies {
66
compileOnly("org.apache.commons:commons-lang3:3.12.0")
77
testImplementation("org.apache.commons:commons-lang3:3.12.0")
88

9-
testInstrumentation(project(":instrumentation:internal:internal-class-loader:javaagent", configuration = "shadow"))
9+
testInstrumentation(project(":instrumentation:internal:internal-class-loader:javaagent", configuration = "shaded"))
1010
}

instrumentation/internal/internal-class-loader/javaagent/build.gradle.kts

Lines changed: 26 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import com.github.jengelman.gradle.plugins.shadow.tasks.ShadowJar
2+
13
plugins {
24
id("otel.javaagent-instrumentation")
35
}
@@ -23,8 +25,31 @@ dependencies {
2325
testImplementation("org.apache.felix:org.apache.felix.framework:6.0.2")
2426
}
2527

28+
val shadedJar by tasks.registering(ShadowJar::class) {
29+
from(zipTree(tasks.jar.get().archiveFile))
30+
archiveClassifier.set("shaded")
31+
}
32+
2633
tasks {
27-
shadowJar {
34+
withType(ShadowJar::class) {
2835
relocate("io.opentelemetry.javaagent.instrumentation.internal.classloader.stub", "java.lang")
2936
}
37+
38+
assemble {
39+
dependsOn(shadedJar)
40+
}
41+
}
42+
43+
// Create a consumable configuration for the shaded jar. We can't use the "shadow" configuration
44+
// because that is taken by the agent-testing.jar
45+
configurations {
46+
consumable("shaded") {
47+
attributes {
48+
attribute(LibraryElements.LIBRARY_ELEMENTS_ATTRIBUTE, objects.named("shaded"))
49+
}
50+
}
51+
}
52+
53+
artifacts {
54+
add("shaded", shadedJar)
3055
}

javaagent/build.gradle.kts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ dependencies {
9494
baseJavaagentLibs(project(":instrumentation:opentelemetry-instrumentation-annotations-1.16:javaagent"))
9595
baseJavaagentLibs(project(":instrumentation:executors:javaagent"))
9696
baseJavaagentLibs(project(":instrumentation:internal:internal-application-logger:javaagent"))
97-
baseJavaagentLibs(project(":instrumentation:internal:internal-class-loader:javaagent", configuration = "shadow"))
97+
baseJavaagentLibs(project(":instrumentation:internal:internal-class-loader:javaagent", configuration = "shaded"))
9898
baseJavaagentLibs(project(":instrumentation:internal:internal-eclipse-osgi-3.6:javaagent"))
9999
baseJavaagentLibs(project(":instrumentation:internal:internal-lambda:javaagent"))
100100
baseJavaagentLibs(project(":instrumentation:internal:internal-reflection:javaagent"))
@@ -126,7 +126,11 @@ project(":instrumentation").subprojects {
126126

127127
plugins.withId("otel.javaagent-instrumentation") {
128128
javaagentDependencies.run {
129-
add(javaagentLibs.name, project(subProj.path))
129+
// exclude :instrumentation:internal:internal-class-loader:javaagent we added the shaded
130+
// configuration from it to baseJavaagentLibs
131+
if (!subProj.path.contains("internal-class-loader")) {
132+
add(javaagentLibs.name, project(subProj.path))
133+
}
130134
}
131135
}
132136

0 commit comments

Comments
 (0)