virtualfield 2

Author: SylvainJuge

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/ResteasyResourceLocatorInvokerInstrumentation.java

@@ -10,7 +10,6 @@
 
 import io.opentelemetry.context.Context;
 import io.opentelemetry.context.Scope;
-import io.opentelemetry.instrumentation.api.util.VirtualField;
 import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
 import io.opentelemetry.javaagent.bootstrap.jaxrs.JaxrsContextPath;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
@@ -47,8 +46,7 @@ public static Scope onEnter(@Advice.This ResourceLocatorInvoker resourceInvoker)
 
       Context currentContext = Java8BytecodeBridge.currentContext();
 
-      String name =
-          VirtualField.find(ResourceLocatorInvoker.class, String.class).get(resourceInvoker);
+      String name = ResteasySingletons.LOCATOR_NAME.get(resourceInvoker);
       ResteasySpanName.INSTANCE.updateServerSpanName(currentContext, name);
 
       // subresource locator returns a resources class that may have @Path annotations

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/ResteasyResourceMethodInvokerInstrumentation.java

@@ -5,10 +5,10 @@
 
 package io.opentelemetry.javaagent.instrumentation.jaxrs.v2_0;
 
+import static io.opentelemetry.javaagent.instrumentation.jaxrs.v2_0.ResteasySingletons.INVOKER_NAME;
 import static net.bytebuddy.matcher.ElementMatchers.named;
 import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
 
-import io.opentelemetry.instrumentation.api.util.VirtualField;
 import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
@@ -38,9 +38,7 @@ public static class InvokeOnTargetAdvice {
 
     @Advice.OnMethodEnter(suppress = Throwable.class)
     public static void onEnter(@Advice.This ResourceMethodInvoker resourceInvoker) {
-
-      String name =
-          VirtualField.find(ResourceMethodInvoker.class, String.class).get(resourceInvoker);
+      String name = INVOKER_NAME.get(resourceInvoker);
       ResteasySpanName.INSTANCE.updateServerSpanName(Java8BytecodeBridge.currentContext(), name);
     }
   }

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/ResteasyRootNodeTypeInstrumentation.java

@@ -5,11 +5,12 @@
 
 package io.opentelemetry.javaagent.instrumentation.jaxrs.v2_0;
 
+import static io.opentelemetry.javaagent.instrumentation.jaxrs.v2_0.ResteasySingletons.INVOKER_NAME;
+import static io.opentelemetry.javaagent.instrumentation.jaxrs.v2_0.ResteasySingletons.LOCATOR_NAME;
 import static net.bytebuddy.matcher.ElementMatchers.named;
 import static net.bytebuddy.matcher.ElementMatchers.namedOneOf;
 import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
 
-import io.opentelemetry.instrumentation.api.util.VirtualField;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
 import io.opentelemetry.javaagent.instrumentation.jaxrs.JaxrsPathUtil;
@@ -51,12 +52,10 @@ public static void addInvoker(
       String normalizedPath = JaxrsPathUtil.normalizePath(path);
       if (invoker instanceof ResourceLocatorInvoker) {
         ResourceLocatorInvoker resourceLocatorInvoker = (ResourceLocatorInvoker) invoker;
-        VirtualField.find(ResourceLocatorInvoker.class, String.class)
-            .set(resourceLocatorInvoker, normalizedPath);
+        LOCATOR_NAME.set(resourceLocatorInvoker, normalizedPath);
       } else if (invoker instanceof ResourceMethodInvoker) {
         ResourceMethodInvoker resourceMethodInvoker = (ResourceMethodInvoker) invoker;
-        VirtualField.find(ResourceMethodInvoker.class, String.class)
-            .set(resourceMethodInvoker, normalizedPath);
+        INVOKER_NAME.set(resourceMethodInvoker, normalizedPath);
       }
     }
   }

instrumentation/jaxrs/jaxrs-2.0/jaxrs-2.0-resteasy-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/ResteasySingletons.java

@@ -0,0 +1,21 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+package io.opentelemetry.javaagent.instrumentation.jaxrs.v2_0;
+
+import io.opentelemetry.instrumentation.api.util.VirtualField;
+import org.jboss.resteasy.core.ResourceLocatorInvoker;
+import org.jboss.resteasy.core.ResourceMethodInvoker;
+
+public class ResteasySingletons {
+
+  public static final VirtualField<ResourceLocatorInvoker, String> LOCATOR_NAME =
+      VirtualField.find(ResourceLocatorInvoker.class, String.class);
+
+  public static final VirtualField<ResourceMethodInvoker, String> INVOKER_NAME =
+      VirtualField.find(ResourceMethodInvoker.class, String.class);
+
+  private ResteasySingletons() {}
+}