Skip to content

Commit bfe189b

Browse files
authored
Merge pull request #12 from trask/redact-query-string-values
Simplify
2 parents e237ea6 + 6aed2da commit bfe189b

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/semconv/http/HttpClientAttributesExtractor.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ private static String redactQueryParameters(String url) {
175175
boolean inRedactedParamValue =
176176
false; // To be able to skip the characters of the parameters to redact
177177
boolean inParamValue = false;
178-
boolean inReference = false;
179178

180179
// To build a parameter name until we reach the '=' character
181180
// If the parameter name is a one to redact, we will redact the value
@@ -198,11 +197,11 @@ private static String redactQueryParameters(String url) {
198197
currentParamName.setLength(
199198
0); // To avoid creating a new StringBuilder for each new parameter
200199
} else if (currentChar == '#') { // Reference delimiter
201-
inReference = true;
202-
redactedParameters.append('#');
200+
redactedParameters.append(url.substring(i));
201+
break;
203202
} else if (!inParamValue) {
204203
currentParamName.append(currentChar);
205-
} else if (!inRedactedParamValue || inReference) {
204+
} else if (!inRedactedParamValue) {
206205
redactedParameters.append(currentChar);
207206
}
208207
}

0 commit comments

Comments
 (0)