Skip to content

Commit c08a511

Browse files
committed
fix rebase
1 parent a8db58f commit c08a511

File tree

5 files changed

+33
-18
lines changed

5 files changed

+33
-18
lines changed

instrumentation/restlet/restlet-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/restlet/v2_0/RestletSingletons.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import io.opentelemetry.api.GlobalOpenTelemetry;
99
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
1010
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerRouteGetter;
11-
import io.opentelemetry.instrumentation.restlet.v2_0.RestletTelemetry;
11+
import io.opentelemetry.instrumentation.restlet.v2_0.internal.RestletTelemetryBuilderFactory;
1212
import io.opentelemetry.javaagent.bootstrap.internal.JavaagentHttpServerInstrumenters;
1313
import io.opentelemetry.javaagent.bootstrap.servlet.ServletContextPath;
1414
import org.restlet.Request;
@@ -17,7 +17,8 @@
1717
public final class RestletSingletons {
1818

1919
private static final Instrumenter<Request, Response> INSTRUMENTER =
20-
JavaagentHttpServerInstrumenters.create(RestletTelemetry.create(GlobalOpenTelemetry.get()));
20+
JavaagentHttpServerInstrumenters.create(
21+
RestletTelemetryBuilderFactory.create(GlobalOpenTelemetry.get()));
2122

2223
public static Instrumenter<Request, Response> instrumenter() {
2324
return INSTRUMENTER;

instrumentation/restlet/restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/RestletTelemetryBuilder.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@
1111
import io.opentelemetry.instrumentation.api.instrumenter.AttributesExtractor;
1212
import io.opentelemetry.instrumentation.api.instrumenter.SpanNameExtractor;
1313
import io.opentelemetry.instrumentation.api.semconv.http.HttpServerAttributesExtractorBuilder;
14-
import io.opentelemetry.instrumentation.restlet.v2_0.internal.RestletHeadersGetter;
15-
import io.opentelemetry.instrumentation.restlet.v2_0.internal.RestletHttpAttributesGetter;
14+
import io.opentelemetry.instrumentation.restlet.v2_0.internal.RestletTelemetryBuilderFactory;
1615
import java.util.List;
1716
import java.util.Set;
1817
import java.util.function.Function;
@@ -25,10 +24,7 @@ public final class RestletTelemetryBuilder {
2524
private final DefaultHttpServerInstrumenterBuilder<Request, Response> builder;
2625

2726
RestletTelemetryBuilder(OpenTelemetry openTelemetry) {
28-
builder =
29-
new DefaultHttpServerInstrumenterBuilder<>(
30-
"io.opentelemetry.restlet-2.0", openTelemetry, RestletHttpAttributesGetter.INSTANCE)
31-
.setHeaderGetter(new RestletHeadersGetter());
27+
builder = RestletTelemetryBuilderFactory.create(openTelemetry);
3228
}
3329

3430
/**

instrumentation/restlet/restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/internal/RestletHeadersGetter.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,7 @@
1818
import org.restlet.Request;
1919
import org.restlet.util.Series;
2020

21-
/**
22-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
23-
* any time.
24-
*/
25-
public final class RestletHeadersGetter implements TextMapGetter<Request> {
21+
final class RestletHeadersGetter implements TextMapGetter<Request> {
2622

2723
private static final MethodHandle GET_ATTRIBUTES;
2824

instrumentation/restlet/restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/internal/RestletHttpAttributesGetter.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,7 @@
1616
import org.restlet.Response;
1717
import org.restlet.util.Series;
1818

19-
/**
20-
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
21-
* any time.
22-
*/
23-
public enum RestletHttpAttributesGetter implements HttpServerAttributesGetter<Request, Response> {
19+
enum RestletHttpAttributesGetter implements HttpServerAttributesGetter<Request, Response> {
2420
INSTANCE;
2521

2622
@Override
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
package io.opentelemetry.instrumentation.restlet.v2_0.internal;
7+
8+
import io.opentelemetry.api.OpenTelemetry;
9+
import io.opentelemetry.instrumentation.api.incubator.builder.internal.DefaultHttpServerInstrumenterBuilder;
10+
import org.restlet.Request;
11+
import org.restlet.Response;
12+
13+
/**
14+
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
15+
* any time.
16+
*/
17+
public class RestletTelemetryBuilderFactory {
18+
private RestletTelemetryBuilderFactory() {}
19+
20+
public static DefaultHttpServerInstrumenterBuilder<Request, Response> create(
21+
OpenTelemetry openTelemetry) {
22+
return new DefaultHttpServerInstrumenterBuilder<>(
23+
"io.opentelemetry.restlet-2.0", openTelemetry, RestletHttpAttributesGetter.INSTANCE)
24+
.setHeaderGetter(new RestletHeadersGetter());
25+
}
26+
}

0 commit comments

Comments
 (0)