Skip to content

Commit c1ed23c

Browse files
committed
review
1 parent 778c3fc commit c1ed23c

File tree

23 files changed

+21
-33
lines changed

23 files changed

+21
-33
lines changed

.fossa.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,12 @@ targets:
136136
- type: gradle
137137
path: ./
138138
target: ':instrumentation:gwt-2.0:javaagent'
139+
- type: gradle
140+
path: ./
141+
target: ':instrumentation:helidon-4.3:javaagent'
142+
- type: gradle
143+
path: ./
144+
target: ':instrumentation:helidon-4.3:library'
139145
- type: gradle
140146
path: ./
141147
target: ':instrumentation:hikaricp-3.0:javaagent'
@@ -475,12 +481,6 @@ targets:
475481
- type: gradle
476482
path: ./
477483
target: ':instrumentation:graphql-java:graphql-java-common:library'
478-
- type: gradle
479-
path: ./
480-
target: ':instrumentation:helidon:helidon-4.3.0:javaagent'
481-
- type: gradle
482-
path: ./
483-
target: ':instrumentation:helidon:helidon-4.3.0:library'
484484
- type: gradle
485485
path: ./
486486
target: ':instrumentation:hibernate:hibernate-3.3:javaagent'

docs/supported-libraries.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ These are the supported libraries and frameworks:
7676
| [gRPC](https://github.com/grpc/grpc-java) | 1.6+ | [opentelemetry-grpc-1.6](../instrumentation/grpc-1.6/library) | [RPC Client Spans], [RPC Client Metrics], [RPC Server Spans], [RPC Server Metrics] |
7777
| [Guava ListenableFuture](https://guava.dev/releases/snapshot/api/docs/com/google/common/util/concurrent/ListenableFuture.html) | 10.0+ | [opentelemetry-guava-10.0](../instrumentation/guava-10.0/library) | Context propagation |
7878
| [GWT](https://www.gwtproject.org/) | 2.0+ | N/A | [RPC Server Spans] |
79+
| [Helidon](https://helidon.io/) | 4.3+ | [opentelemetry-helidon-4.3](../instrumentation/helidon-4.3/library) | [HTTP Server Spans], [HTTP Server Metrics], Provides `http.route` [2] |
7980
| [Hibernate](https://github.com/hibernate/hibernate-orm) | 3.3+ | N/A | none |
8081
| [Hibernate Reactive](https://hibernate.org/reactive) | 1.0+ | N/A | none |
8182
| [HikariCP](https://github.com/brettwooldridge/HikariCP) | 3.0+ | [opentelemetry-hikaricp-3.0](../instrumentation/hikaricp-3.0/library) | [Database Pool Metrics] |

instrumentation/helidon/helidon-4.3.0/javaagent/build.gradle.kts renamed to instrumentation/helidon-4.3/javaagent/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ otelJava {
1717

1818
dependencies {
1919
library("io.helidon.webserver:helidon-webserver:4.3.0")
20-
implementation(project(":instrumentation:helidon:helidon-4.3.0:library"))
21-
testImplementation(project(":instrumentation:helidon:helidon-4.3.0:testing"))
20+
implementation(project(":instrumentation:helidon-4.3:library"))
21+
testImplementation(project(":instrumentation:helidon-4.3:testing"))
2222
}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
@AutoService(InstrumentationModule.class)
1616
public class HelidonInstrumentationModule extends InstrumentationModule {
1717
public HelidonInstrumentationModule() {
18-
super("helidon", "helidon-4.3.0");
18+
super("helidon", "helidon-4.3");
1919
}
2020

2121
@Override

instrumentation/helidon/helidon-4.3.0/library/README.md renamed to instrumentation/helidon-4.3/library/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ Provides OpenTelemetry instrumentation for [Helidon](https://helidon.io/).
77
### Add these dependencies to your project
88

99
Replace `OPENTELEMETRY_VERSION` with the [latest
10-
release](https://search.maven.org/search?q=g:io.opentelemetry.instrumentation%20AND%20a:opentelemetry-helidon-4.3.0).
10+
release](https://search.maven.org/search?q=g:io.opentelemetry.instrumentation%20AND%20a:opentelemetry-helidon-4.3).
1111

1212
For Maven, add to your `pom.xml` dependencies:
1313

1414
```xml
1515
<dependencies>
1616
<dependency>
1717
<groupId>io.opentelemetry.instrumentation</groupId>
18-
<artifactId>opentelemetry-helidon-4.3.0</artifactId>
18+
<artifactId>opentelemetry-helidon-4.3</artifactId>
1919
<version>OPENTELEMETRY_VERSION</version>
2020
</dependency>
2121
</dependencies>
@@ -24,7 +24,7 @@ For Maven, add to your `pom.xml` dependencies:
2424
For Gradle, add to your dependencies:
2525

2626
```groovy
27-
implementation("io.opentelemetry.instrumentation:opentelemetry-helidon-4.3.0:OPENTELEMETRY_VERSION")
27+
implementation("io.opentelemetry.instrumentation:opentelemetry-helidon-4.3:OPENTELEMETRY_VERSION")
2828
```
2929

3030
### Usage

0 commit comments

Comments
 (0)