distro provider: declarative config uses snake case (#15260)

Author: zeitlinger

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/resources/DistroComponentProvider.java

@@ -20,7 +20,7 @@ public Class<Resource> getType() {
 
   @Override
   public String getName() {
-    return "opentelemetry-javaagent-distribution";
+    return "opentelemetry_javaagent_distribution";
   }
 
   @Override

javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/resources/ResourceCustomizerProvider.java

@@ -24,10 +24,10 @@
 @AutoService(DeclarativeConfigurationCustomizerProvider.class)
 public class ResourceCustomizerProvider implements DeclarativeConfigurationCustomizerProvider {
 
-  // opentelemetry-javaagent-distribution: adds "distro.name" and "distro.version" attributes
+  // opentelemetry_javaagent_distribution: adds "distro.name" and "distro.version" attributes
   // (DistroComponentProvider in this package)
   private static final List<String> REQUIRED_DETECTORS =
-      Collections.singletonList("opentelemetry-javaagent-distribution");
+      Collections.singletonList("opentelemetry_javaagent_distribution");
 
   @Override
   public void customize(DeclarativeConfigurationCustomizer customizer) {

javaagent-tooling/src/test/java/io/opentelemetry/javaagent/tooling/resources/ResourceCustomizerProviderTest.java

@@ -27,7 +27,7 @@ void customize() {
               try {
                 assertThat(objectMapper.writeValueAsString(configurationModel.getResource()))
                     .isEqualTo(
-                        "{\"attributes\":[],\"detection/development\":{\"detectors\":[{\"opentelemetry-javaagent-distribution\":null}]}}");
+                        "{\"attributes\":[],\"detection/development\":{\"detectors\":[{\"opentelemetry_javaagent_distribution\":null}]}}");
               } catch (JsonProcessingException e) {
                 throw new AssertionError(e);
               }